T2370
The use of BCH.Address.toCashAddress in sendXec() is actually redundant because both outputAddress and destinationAddress variables are already in bch format prior to the call.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC21fa4dafe346: [Cashtab] [BCH deprecation] Pt 1/1 - Deprecate BCH.Address.toCashAddress from…
npm test and ensure existing unit test suite passes
npm start
send a simple XEC tx and sense check the tx in explorer
send a one to one XEC tx with unencrypted message
send a one to one XEC tx with encrypted message
send a one to many XEC tx
send a one to many XEC tx with unencrypted message
grep -r 'BCH.Address.toCashAddress' src/ and ensure no further usage of the bch-js function
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- deprecateToCashAddress
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 20754 Build 41172: Build Diff cashtab-tests Build 41171: arc lint + arc unit