Page MenuHomePhabricator
Differential D12397

[Cashtab] [BCH deprecation] Pt 1/2 - Implement local HD node derivePath logic
AbandonedPublic
Actions

Authored by emack on Oct 31 2022, 03:27.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

T2370

As a prerequisite to deprecating BCH.HDNode.derivePath, this diff implements this locally within Cashtab.

Test Plan
  • npm test
  • npm start
  • create a new wallet and observe 3 x 'BCH-JS node output matches localNode' console log messages relfecting the active wallet's Path245, Path145 and Path1899 derivations

Diff Detail

Repository
rABC Bitcoin ABC
Branch
hdnode
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20768
Build 41199: Build Diffcashtab-tests
Build 41198: arc lint + arc unit

Event Timeline

emack created this revision.Oct 31 2022, 03:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 31 2022, 03:27
emack requested review of this revision.Oct 31 2022, 03:27
Harbormaster completed remote builds in B20768: Diff 36078.Oct 31 2022, 03:30
emack added a child revision: D12398: [Cashtab] [BCH deprecation] Pt 2/2 - Deprecate BCH.HDNode.derivePath.Oct 31 2022, 04:22
bytesofman requested changes to this revision.Oct 31 2022, 16:45

It's not clear what we are accomplishing here since masterHDNode is still being derived from BCH before calling the deriveAccount function. Fix it at the top level and then carrying it down.

This revision now requires changes to proceed.Oct 31 2022, 16:45
bytesofman mentioned this in D12398: [Cashtab] [BCH deprecation] Pt 2/2 - Deprecate BCH.HDNode.derivePath.Oct 31 2022, 16:46
emack abandoned this revision.Nov 26 2022, 05:19

superseded by D12414 stack

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
6 lines

Diff 36078

View Options

web/cashtab/src/hooks/useWallet.js

Loading...