Differential D12398

[Cashtab] [BCH deprecation] Pt 2/2 - Deprecate BCH.HDNode.derivePath
AbandonedPublic
Actions

Authored by emack on Oct 31 2022, 04:22.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Summary

T2730

Depends on D12397

This diff switches the HD Node derivePath logic to the local implementation.

Test Plan

grep -r 'BCH.HDNode.derivePath' src/ and ensure no further uses of this method throughout the app
npm test
npm start
create a new wallet and ensure successful wallet generation
send an XEC tx to this wallet and ensure it is successfully received

Diff Detail

Repository

rABC Bitcoin ABC

Branch

hdnode

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20769
Build 41201: Build Diff	cashtab-tests
Build 41200: arc lint + arc unit

Event Timeline

emack created this revision.Oct 31 2022, 04:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 31 2022, 04:22

emack requested review of this revision.Oct 31 2022, 04:22

emack edited the summary of this revision. (Show Details)Oct 31 2022, 04:24

Harbormaster completed remote builds in B20769: Diff 36079.Oct 31 2022, 04:24

Same feedback as for D12397

This revision now requires changes to proceed.Oct 31 2022, 16:46

superseded by D12414 stack

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

hooks/

useWallet.js

8 lines

Diff 36079

View Options

web/cashtab/src/hooks/useWallet.js

[Cashtab] [BCH deprecation] Pt 2/2 - Deprecate BCH.HDNode.derivePathAbandonedPublicActions