Page MenuHomePhabricator
Differential D12399

[Cashtab] [BCH deprecation] Pt 1/2 - Implement local HD node toPublicKey logic
AbandonedPublic
Actions

Authored by emack on Oct 31 2022, 04:37.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

T2730

As a prerequisite to deprecating BCH.HDNode.toPublicKey this diff implements this locally within Cashtab

Test Plan

npm test
npm start
create a new wallet and observe 3 x 'BCH-JS publicKey output matches localPublicKey' console log messages relfecting the active wallet's Path245, Path145 and Path1899 derivations

Diff Detail

Repository
rABC Bitcoin ABC
Branch
hdnodeToPublicKey
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20770
Build 41203: Build Diffcashtab-tests
Build 41202: arc lint + arc unit

Event Timeline

emack created this revision.Oct 31 2022, 04:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 31 2022, 04:37
emack requested review of this revision.Oct 31 2022, 04:37
Harbormaster completed remote builds in B20770: Diff 36080.Oct 31 2022, 04:40
emack added a child revision: D12400: [Cashtab] [BCH deprecation] Pt 2/2 - Deprecate BCH.HDNode.toPublicKey.Oct 31 2022, 04:46
bytesofman requested changes to this revision.Oct 31 2022, 16:47

masterHDNode is still coming from BCH before deriveAccount is called; this is what needs to be corrected before propagating downstream

This revision now requires changes to proceed.Oct 31 2022, 16:47
emack abandoned this revision.Nov 26 2022, 05:19

superseded by D12414 stack

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
8 lines

Diff 36080

View Options

web/cashtab/src/hooks/useWallet.js

Loading...