Page MenuHomePhabricator

[Cashtab] [BCH deprecation] Pt 2/2 - Deprecate BCH.HDNode.toPublicKey
AbandonedPublic

Authored by emack on Oct 31 2022, 04:46.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

T2730

Depends on D12399

This diff switches the HD Node toPublicKey logic to the local implementation.

Test Plan
  • grep -r 'BCH.HDNode.toPublicKey' src/ and ensure no further uses of this method throughout the app
  • npm test
  • npm start
  • send an encrypted XEC message tx to this wallet and ensure it is successfully received and decrypted
  • create a new wallet and ensure successful wallet generation
  • send an encrypted XEC message tx to this new wallet and ensure it is successfully received and decrypted

Diff Detail

Repository
rABC Bitcoin ABC
Branch
hdnodeToPublicKey
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20771
Build 41205: Build Diffcashtab-tests
Build 41204: arc lint + arc unit