T2730
As a prerequisite to deprecating BCH.HDNode.toWIF this diff implements this locally within Cashtab
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project
npm test
npm start
create a new wallet and observe 3 x 'BCH-JS toWIF() output matches local toWIF()' console log messages relfecting the active wallet's Path245, Path145 and Path1899 derivations
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- hdnodeToWif
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 20772 Build 41207: Build Diff cashtab-tests Build 41206: arc lint + arc unit
Event Timeline
Comment Actions
Ping me on TG if I'm missing something about what you are looking to implement here. Because masterHDNode, the input to this function, is itself derived from BCH, it looks like these diffs can be avoided --- provided masterHDNode is implemented locally.
It's also a bit confusing here because the stacks are disconnected. In this series of diffs, the stack should include all of these removals, so that reviewer can observe what's already been established.