Page MenuHomePhabricator
Differential D12402

[Cashtab] [BCH deprecation] Pt 2/2 - Deprecate BCH.HDNode.toWIF
AbandonedPublic
Actions

Authored by emack on Oct 31 2022, 07:30.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

T2730

Depends on D12401

This diff switches the HD Node toWIF() logic to the local implementation.

Test Plan
  • grep -r 'BCH.HDNode.toWIF' src/ and ensure no further uses of this method throughout the app
  • npm test
  • npm start
  • create a new wallet and ensure successful wallet generation
  • send an XEC tx from this new wallet and ensure it is successfully sent

Diff Detail

Repository
rABC Bitcoin ABC
Branch
hdnodeToWif
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20773
Build 41209: Build Diffcashtab-tests
Build 41208: arc lint + arc unit

Event Timeline

emack created this revision.Oct 31 2022, 07:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 31 2022, 07:30
emack requested review of this revision.Oct 31 2022, 07:30
Harbormaster completed remote builds in B20773: Diff 36083.Oct 31 2022, 07:32
bytesofman requested changes to this revision.Oct 31 2022, 16:53

I can follow your logic here after going through the various 2-part diffs. However, it's confusing. I think this needs to be reworked as a larger stacked diff.

  • show that all of these BCH.HDNode calls are redundant as you have done in these parts, but do it sequentially and in a larger stack, so that by the end, none are left in the function
  • Must also include deriving masterHDNode without BCHJS
This revision now requires changes to proceed.Oct 31 2022, 16:53
emack abandoned this revision.Nov 26 2022, 05:20

superseded by D12414 stack

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
9 lines

Diff 36083

View Options

web/cashtab/src/hooks/useWallet.js

Loading...