Related to T2744. Removed ability to scroll within amount input fields in SendBch, Burn eToken amount input and Send eToken amount input. I think this is a welcome change and should be implemented.
Details
Details
- Reviewers
bytesofman emack - Group Reviewers
Restricted Project - Commits
- rABC7a3969b8bf62: [Cashtab] Disabled scroll wheel within input fields
cd web/cashtab && npm start
navigate to Send screen
click on the 'Amount' input and scroll
observe that the input loses focus
navigate to send eToken screen
click on the 'Amount' input and scroll
observe that the input loses focus
on the same screen, click on the 'Burn eToken' input and scroll
observe that the input loses focus
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- disable-scrolling-within-input-fields
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 20790 Build 41242: Build Diff cashtab-tests Build 41241: arc lint + arc unit
Event Timeline
Comment Actions
Because the intention here is to implement this across the entire app -- this onWheel prop should be added to the component where it is defined, i.e. in EnhancedInputs.js (unless it is not possible / practical to do so, in this case need some discussion in the diff about why)
Comment Actions
Responding to review feedback, removed onWheel from inputProps in SendToken.js which was left in by mistake in last push, added comments to explain why target.blur() is used in this case instead of event.preventDefault().