Related to T2734, depends on D12428. Message signing and verification collapses should be on their own screen. Part 3 of this diff is the addition of the new SignVerifyMsg directory / component. Routes have been added in extension/src/components/App.js and web/cashtab/src/components/App.js. Per review feedback in D12417, cashtabSettings and changeCashtabSettings are not passed through App.js, but pulled from context the same way as is done on other screens.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC3eae42cbf944: [Cashtab][Pt 3/4] Move message signing and verification to new screen - create…
cd web/cashtab && npm start
navigate to Send.js
observe that the Sign and verify message collapses are no longer there
expand the hamburger menu
click Sign and Verify
observe that the new component is rendered at the route /signverifymsg
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- move-message-signing-verification-to-new-screen
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 20823 Build 41305: Build Diff cashtab-tests Build 41304: arc lint + arc unit
Event Timeline
Comment Actions
One issue that will come up for all of these 'bonus' screens, there isn't a visual navigation aid to know where you are as the user.
Here we are at the new screen:
For other screens, the icon is highlighted in the tray, like this:
We'll need some kind of elegant way to handle this that can consistently be applied to all screens no longer on the main nav bar.
This issue already applies to the Settings page, so it's not really related to this diff and does not need to be handled here. Please create a task to handle this issue. Maybe display the highlighted icon in a fixed position in the lower right hand corner of the app. Will need to try it out and see what looks best.