Differential D12432

test: Speed up rpc_blockchain.py by removing miniwallet.generate()
ClosedPublic
Actions

Authored by Fabien on Nov 8 2022, 08:54.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCea30d0e4cc9c: test: Speed up rpc_blockchain.py by removing miniwallet.generate()

Summary

Speed up various tests:

    Remove unused nodes, which only consume time on start/stop
    Remove unused "bug workarounds"
    Remove the need for miniwallet.generate() by adding miniwallet.scan_blocks(). (On my system, with valgrind, generating 105 blocks takes 3.31 seconds. Rescanning 5 blocks takes 0.11 seconds.)

Backport of core#21200.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR21200

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20825
Build 41309: Build Diff	build-diff · build-debug · build-without-wallet · build-clang · build-clang-tidy
Build 41308: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 8 2022, 08:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 8 2022, 08:54

Fabien requested review of this revision.Nov 8 2022, 08:54

teamcity edited the summary of this revision. (Show Details)Nov 8 2022, 08:54

Harbormaster completed remote builds in B20825: Diff 36163.Nov 8 2022, 09:06

Fabien added a child revision: D12434: test: Speed up mempool_spend_coinbase.py.Nov 8 2022, 12:41

sdulfari accepted this revision.Nov 8 2022, 17:48

This revision is now accepted and ready to land.Nov 8 2022, 17:48

Closed by commit rABCea30d0e4cc9c: test: Speed up rpc_blockchain.py by removing miniwallet.generate() (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyNov 9 2022, 09:23

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCea30d0e4cc9c: test: Speed up rpc_blockchain.py by removing miniwallet.generate().

Revision Contents
Changeset List

Path

Size

test/

functional/

rpc_blockchain.py

15 lines

test_framework/

test_framework.py

14 lines

11 lines

wallet_txn_clone.py

8 lines

wallet_txn_doublespend.py

8 lines

Diff 36163

test/functional/rpc_blockchain.py

Loading...

test/functional/test_framework/test_framework.py

Loading...

test/functional/test_framework/wallet.py

Loading...

test/functional/wallet_txn_clone.py

Loading...

test/functional/wallet_txn_doublespend.py

Loading...