add missing lock assertion to removeForReorg
ClosedPublic
Actions

Authored by PiRK on Nov 9 2022, 09:03.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC15178386be7c: add missing lock assertion to removeForReorg

Summary

removeForReorg has the EXCLUSIVE_LOCKS_REQUIRED(cs, cs_main) annotation.
It calls TestLockPointValidity which also has the cs_main lock annotation and assertion.

This lock assertion would normally be added in commit https://github.com/bitcoin/bitcoin/pull/22677/commits/bb9078ed51159fa162484f16993313ed6cf980e3, but it is useful immediately.

Test Plan

with clang and DEBUG:

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 9 2022, 09:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 9 2022, 09:03

PiRK requested review of this revision.Nov 9 2022, 09:03

PiRK added a child revision: D12440: TestLockPointValidity to txmempool.Nov 9 2022, 09:06

that does not seem to be enough to solve the issue

Harbormaster completed remote builds in B20837: Diff 36181.Nov 9 2022, 09:18

even though this is not the fix for D12440, it is still correct.

PiRK edited the summary of this revision. (Show Details)Nov 9 2022, 10:13

PiRK requested review of this revision.Nov 9 2022, 15:58

Fabien accepted this revision.Nov 9 2022, 17:29

This revision is now accepted and ready to land.Nov 9 2022, 17:29

Closed by commit rABC15178386be7c: add missing lock assertion to removeForReorg (authored by PiRK). · Explain WhyNov 10 2022, 08:50

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC15178386be7c: add missing lock assertion to removeForReorg.

Revision Contents
Changeset List

Path

Size

src/

txmempool.cpp

2 lines

Diff 36214

View Options

add missing lock assertion to removeForReorgClosedPublicActions