change TestLockPointValidity to take a const reference
ClosedPublic
Actions

Authored by PiRK on Nov 10 2022, 08:40.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC3b8d42aff6ae: change TestLockPointValidity to take a const reference

Summary

The lockpoints are not changed in this function.
There is no reason to pass a pointer.

Note for review: this is backported out of order after core#23683

This concludes backport of core#23649
https://github.com/bitcoin/bitcoin/pull/23649/commits/c4efc4db5484910ac33ba41aa76f4e23639d6f33

Depends on D12448

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 10 2022, 08:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 10 2022, 08:40

PiRK requested review of this revision.Nov 10 2022, 08:40

teamcity edited the summary of this revision. (Show Details)Nov 10 2022, 08:40

PiRK added a child revision: D12454: MOVEONLY: update_lock_points to txmempool.h.Nov 10 2022, 08:46

Harbormaster completed remote builds in B20860: Diff 36212.Nov 10 2022, 08:58

Fabien accepted this revision.Nov 10 2022, 13:42

This revision is now accepted and ready to land.Nov 10 2022, 13:42

Closed by commit rABC3b8d42aff6ae: change TestLockPointValidity to take a const reference (authored by glozow <gloriajzhao@gmail.com>, committed by PiRK). · Explain WhyNov 10 2022, 15:06

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC3b8d42aff6ae: change TestLockPointValidity to take a const reference.

Revision Contents
Changeset List

Path

Size

src/

txmempool.h

2 lines

txmempool.cpp

11 lines

Diff 36239

View Options

src/txmempool.h