Differential D12450

[Cashtab] [BCH Deprecation] [Mnemonic] Pt 1/7 - Implement BCH.Mnemonic.toSeed locally
ClosedPublic
Actions

Authored by emack on Nov 10 2022, 06:40.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC56fe40261d9c: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 1/7 - Implement BCH.Mnemonic.toSeed…

Summary

T2730

Stacked diff to localize existing uses of BCH.Mnemonic throughout the app and deprecate the BCH.Mnemonic object.

Relies on the BIP39 library for mnemonic operation.

Pt 1/7 - Implement BCH.Mnemonic.toSeed locally
Pt 2/7 - Implement BCH.Mnemonic.generate locally
Pt 3/7 - Implement BCH.Mnemonic.wordLists locally
Pt 4/7 - Implement BCH.Mnemonic.validate locally
Pt 5/7 - Deprecate BCH.Mnemonic throughout the app
Pt 6/7 - Optimize bip39 bundle via webpack IgnorePlugin
Pt 7/7 - Unwrap validateMnemonicWordList

Test Plan

npm test
npm start
create a new wallet and observe the 'mnemonicToSeed() output match' console log

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20994
Build 41642: Build Diff	cashtab-tests
Build 41641: arc lint + arc unit

Event Timeline

emack created this revision.Nov 10 2022, 06:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 10 2022, 06:40

emack requested review of this revision.Nov 10 2022, 06:40

Harbormaster completed remote builds in B20856: Diff 36204.Nov 10 2022, 06:43

emack added a child revision: D12451: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 2/7 - Implement BCH.Mnemonic.generate locally.Nov 10 2022, 07:09

bytesofman accepted this revision.Nov 10 2022, 09:55

This revision is now accepted and ready to land.Nov 10 2022, 09:55

emack retitled this revision from [Cashtab] [BCH Deprecation] [Mnemonic] Pt 1/5 - Implement BCH.Mnemonic.toSeed locally to [Cashtab] [BCH Deprecation] [Mnemonic] Pt 1/6 - Implement BCH.Mnemonic.toSeed locally.Nov 10 2022, 12:58

emack edited the summary of this revision. (Show Details)

emack retitled this revision from [Cashtab] [BCH Deprecation] [Mnemonic] Pt 1/6 - Implement BCH.Mnemonic.toSeed locally to [Cashtab] [BCH Deprecation] [Mnemonic] Pt 1/7 - Implement BCH.Mnemonic.toSeed locally.Nov 14 2022, 12:04

emack edited the summary of this revision. (Show Details)

rebase

Harbormaster completed remote builds in B20994: Diff 36411.Nov 20 2022, 00:24

Closed by commit rABC56fe40261d9c: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 1/7 - Implement BCH.Mnemonic.toSeed… (authored by emack). · Explain WhyNov 22 2022, 21:49

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABC56fe40261d9c: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 1/7 - Implement BCH.Mnemonic.toSeed….