Page MenuHomePhabricator
Differential D12461

[Cashtab] [p4 local msg verify] Deprecate segwit support from xecjs-message verify
ClosedPublic
Actions

Authored by bytesofman on Nov 10 2022, 12:03.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCfeb8c2e7082b: [Cashtab] [p4 local msg verify] Deprecate segwit support from xecjs-message…
Summary

T2730

Depends on D12460

Remove segwit support from the verify function of xecjs-message, since this is irrelevant to any xec application

In the future, may wish to remove segwit support from all of xecjs-message. However this is beyond the scope of this individual task.

Test Plan
cd web/cashtab
npm start

Sign and verify msgs, confirm still works

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Nov 10 2022, 12:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 10 2022, 12:03
bytesofman requested review of this revision.Nov 10 2022, 12:03
Harbormaster completed remote builds in B20868: Diff 36225.Nov 10 2022, 12:03
bytesofman updated this revision to Diff 36227.Nov 10 2022, 12:07

Changelog and version bump

Harbormaster completed remote builds in B20870: Diff 36227.Nov 10 2022, 12:07
bytesofman added a child revision: D12462: [Cashtab] [p5 local msg verify] Support for verifying ecash signed msgs in xecjs-message verify.Nov 10 2022, 12:12
emack accepted this revision.Nov 13 2022, 12:55
This revision is now accepted and ready to land.Nov 13 2022, 12:55
bytesofman updated this revision to Diff 36275.Nov 14 2022, 11:51

rebase

Harbormaster completed remote builds in B20899: Diff 36275.Nov 14 2022, 11:51
Closed by commit rABCfeb8c2e7082b: [Cashtab] [p4 local msg verify] Deprecate segwit support from xecjs-message… (authored by bytesofman). · Explain WhyNov 14 2022, 15:26
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCfeb8c2e7082b: [Cashtab] [p4 local msg verify] Deprecate segwit support from xecjs-message….

Revision Contents
Changeset List

PathSize
web/
xecjs-message/
6 lines
49 lines
2 lines

Diff 36290

View Options

web/xecjs-message/CHANGELOG.md

Loading...
View Options

web/xecjs-message/index.js

Loading...
View Options

web/xecjs-message/package.json

Loading...