[Cashtab] [p5 local msg verify] Support for verifying ecash signed msgs in xecjs-message verify
ClosedPublic
Actions

Authored by bytesofman on Nov 10 2022, 12:12.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC39d9045522d4: [Cashtab] [p5 local msg verify] Support for verifying ecash signed msgs in…

Summary

T2730

Depends on D12461

Modify the verify function to return true for messages signed with ecash prefix or bitcoin prefix

Test Plan

cd web/cashtab
npm start

In ElectrumABC, sign a message with ecash prefix
Run it through Verify
Notice in the dev log that newVerification is true, while verification is false

In cashtab, sign a message
Run it through verify
Notice that both approaches match

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Nov 10 2022, 12:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 10 2022, 12:12

bytesofman requested review of this revision.Nov 10 2022, 12:12

Harbormaster completed remote builds in B20871: Diff 36228.Nov 10 2022, 12:12

bytesofman added a child revision: D12463: [Cashtab] [p6 local msg verify] Removed unused functions from xecjs-message verify.Nov 10 2022, 12:18

bytesofman mentioned this in D12464: [Cashtab] [p7 local msg verify] Install published dependency.Nov 10 2022, 12:30

Upon signature verification success, I'm only seeing "Both signature verification methods return the same result" but no sign of newVerification or verification indicators in the logs.

This revision now requires changes to proceed.Nov 13 2022, 14:04

In D12462#278700, @emack wrote:

Upon signature verification success, I'm only seeing "Both signature verification methods return the same result" but no sign of newVerification or verification indicators in the logs.

This is expected behavior, the dev console only prints out the values if they are not the same

emack accepted this revision.Nov 14 2022, 10:40

This revision is now accepted and ready to land.Nov 14 2022, 10:40

rebase

Harbormaster completed remote builds in B20900: Diff 36276.Nov 14 2022, 11:51

Closed by commit rABC39d9045522d4: [Cashtab] [p5 local msg verify] Support for verifying ecash signed msgs in… (authored by bytesofman). · Explain WhyNov 14 2022, 15:26

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC39d9045522d4: [Cashtab] [p5 local msg verify] Support for verifying ecash signed msgs in….

bytesofman mentioned this in rABCcf315a7cc3f1: [Cashtab] [p7 local msg verify] Install published dependency.