Page MenuHomePhabricator

[Cashtab] Visual navigation aid added for hamburger menu options
ClosedPublic

Authored by kieran709 on Nov 10 2022, 18:03.

Details

Summary

Related to T2774. Added visual navigation aid when user is on one of the screens accessed through the hamburger menu.

Test Plan

cd web/cashtab && npm start
navigate to the Airdrop screen
observe that the Airdrop icon is present on the bottom right hand side of the screen
navigate to the SignVerifyMsg screen
observe that the SignVerifyMsg icon is present on the bottom right hand side of the screen
navigate to the Settings screen
observe that the Settings icon is present on the bottom right hand side of the screen

Diff Detail

Repository
rABC Bitcoin ABC
Branch
visual-navigation-aid
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20884
Build 41425: Build Diffcashtab-tests
Build 41424: arc lint + arc unit

Event Timeline

I think the highlighted icon is a little too much clutter.

Let's go for this approach:

  1. Add a small title bar for each page. Placement across the top. Width 100%.
  2. When a page in the menu is selected, highlight that logo in the closed hamburger menu (so when the user opens the hamburger menu, they see which page is selected)
This revision now requires changes to proceed.Nov 15 2022, 09:57

Responding to review feedback. Navigation aid has been added above the Cashtab logo, and the active NavItem is highlighted.

After some consideration, the visual navigation aid has been moved below the Cashtab logo.

Also apply to extension

This revision now requires changes to proceed.Nov 17 2022, 06:16

Responding to review feedback

This revision is now accepted and ready to land.Nov 19 2022, 15:20