[Cashtab] [ECPair from wif p8] Simplify function
AbandonedPublic
Actions

Authored by bytesofman on Nov 15 2022, 12:19.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Summary

T2730

Depends on D12494

Remove the ambiguous data variable and simply return the encoded value

Test Plan

npm test and unit tests still pass
npm start and msg sending still works

Diff Detail

Repository

rABC Bitcoin ABC

Branch

local-ecpair

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20920
Build 41497: Build Diff	cashtab-tests
Build 41496: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 15 2022, 12:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 15 2022, 12:19

bytesofman requested review of this revision.Nov 15 2022, 12:19

bytesofman added a child revision: D12496: [Cashtab] [ECPair from wif p9] Remove unused imports from cashMethods.test.js.Nov 15 2022, 12:21

Harbormaster completed remote builds in B20920: Diff 36304.Nov 15 2022, 12:22

emack accepted this revision.Nov 19 2022, 09:26

This revision is now accepted and ready to land.Nov 19 2022, 09:26

rebase

Harbormaster completed remote builds in B21079: Diff 36552.Nov 23 2022, 11:04

Superseded by D12639

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

utils/

cashMethods.js

4 lines

Diff 36304

View Options

web/cashtab/src/utils/cashMethods.js

[Cashtab] [ECPair from wif p8] Simplify functionAbandonedPublicActions