[Cashtab] [Extension] [Code cleanup p5] Update comments and function name for triggerApprovalModal
AbandonedPublic
Actions

Authored by bytesofman on Nov 15 2022, 14:47.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

T2751

Depends on D12504

Rename function and clean up comments

Test Plan

npm run extension
Update your local extension build and ensure that it is the only active cashtab extension
go to components.cashtab.com
confirm address sharing still works

Diff Detail

Repository

rABC Bitcoin ABC

Branch

extension-code-quality-audit

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20959
Build 41574: Build Diff	cashtab-tests
Build 41573: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 15 2022, 14:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 15 2022, 14:47

bytesofman requested review of this revision.Nov 15 2022, 14:47

Harbormaster completed remote builds in B20930: Diff 36315.Nov 15 2022, 14:50

rebase

Harbormaster completed remote builds in B20958: Diff 36354.Nov 16 2022, 17:21

Harbormaster completed remote builds in B20959: Diff 36355.

bytesofman abandoned this revision.Nov 21 2022, 10:12

Revision Contents
Changeset List

Path

Size

web/

cashtab/

extension/

src/

background.js

6 lines

Diff 36355

View Options

web/cashtab/extension/src/background.js

[Cashtab] [Extension] [Code cleanup p5] Update comments and function name for triggerApprovalModalAbandonedPublicActions