[Cashtab] [Extension] [Code cleanup p1] Remove unused variables from background.js
AbandonedPublic
Actions

Authored by bytesofman on Nov 15 2022, 14:24.

Details

Reviewers

kieran709

Group Reviewers

Restricted Project

Summary

T2751

Cashtab's extension codebase contains artifacts and some unused variables that were connected with the earliest versions, before getting it set up properly in the monorepo.

This stack goes through and cleans up background.js and contentscript.js

In this diff, unused variables are removed from background.js

Test Plan

npm run extension
Build is good, works

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20954
Build 41564: Build Diff	cashtab-tests
Build 41563: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 15 2022, 14:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 15 2022, 14:24

bytesofman requested review of this revision.Nov 15 2022, 14:24

Harbormaster completed remote builds in B20926: Diff 36311.Nov 15 2022, 14:27

bytesofman added a child revision: D12502: [Cashtab] [Extension] [Code cleanup p2] Remove unused window variable from background.js.Nov 15 2022, 14:29

kieran709 accepted this revision.Nov 15 2022, 15:30

This revision is now accepted and ready to land.Nov 15 2022, 15:30

rebase

Harbormaster completed remote builds in B20954: Diff 36350.Nov 16 2022, 17:18

bytesofman added a child revision: D12503: [Cashtab] [Extension] [Code cleanup p3] Remove commented out testing code from background.js.Nov 21 2022, 09:45

bytesofman abandoned this revision.Nov 21 2022, 10:04

Revision Contents
Changeset List

Path

Size

web/

cashtab/

extension/

src/

background.js

5 lines

Diff 36350

View Options

web/cashtab/extension/src/background.js

[Cashtab] [Extension] [Code cleanup p1] Remove unused variables from background.jsAbandonedPublicActions