Differential D12522

test: Implicitly sync after generate*, unless opted out
ClosedPublic
Actions

Authored by Fabien on Nov 17 2022, 12:32.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCa219f148b4c0: test: Implicitly sync after generate*, unless opted out

Summary

Backport of core#23300.

Depends on D12521.

Note: There are some extra sync_* calls after this diff, which are left as-is because they are cheap and the diff is already large enough.

Test Plan

ninja check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR23300

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20967
Build 41590: Build Diff	build-without-wallet · build-diff · build-clang-tidy · build-debug · build-clang
Build 41589: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 17 2022, 12:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 17 2022, 12:32

Fabien requested review of this revision.Nov 17 2022, 12:32

teamcity edited the summary of this revision. (Show Details)Nov 17 2022, 12:32

Harbormaster completed remote builds in B20967: Diff 36372.Nov 17 2022, 12:47

PiRK accepted this revision.Nov 17 2022, 13:47

This revision is now accepted and ready to land.Nov 17 2022, 13:47

Closed by commit rABCa219f148b4c0: test: Implicitly sync after generate*, unless opted out (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyNov 17 2022, 13:48

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa219f148b4c0: test: Implicitly sync after generate*, unless opted out.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc-finalize-block.py

31 lines

abc-get-invalid-block.py

3 lines

abc-magnetic-anomaly-mining.py

2 lines

abc-minimaldata.py

3 lines

abc-parkedchain.py

67 lines

abc-schnorr.py

6 lines

abc-schnorrmultisig.py

3 lines

abc_feature_minerfund.py

8 lines

abc_feature_proof_cleanup.py

2 lines

abc_p2p_avalanche_peer_discovery.py

9 lines

abc_p2p_avalanche_proof_voting.py

8 lines

abc_p2p_avalanche_quorum.py

2 lines

abc_p2p_avalanche_transaction_voting.py

4 lines

abc_p2p_avalanche_voting.py

9 lines

abc_p2p_getavaaddr.py

8 lines

abc_p2p_proof_inventory.py

8 lines

abc_rpc_addavalanchenode.py

3 lines

abc_rpc_avalancheproof.py

17 lines

abc_rpc_buildavalancheproof.py

3 lines

abc_rpc_getavalancheinfo.py

8 lines

abc_rpc_getavalanchepeerinfo.py

3 lines

abc_rpc_getavalancheproofs.py

8 lines

abc_rpc_isfinal.py

6 lines

abc_wallet_dumpcoins.py

3 lines

abc_wallet_standardness.py

4 lines

example_test.py

4 lines

feature_abortnode.py

6 lines

feature_bip68_sequence.py

11 lines

feature_coinstatsindex.py

4 lines

feature_dbcrash.py

4 lines

feature_loadblock.py

2 lines

feature_minchainwork.py

9 lines

feature_notifications.py

6 lines

15 lines

23 lines

2 lines

6 lines

mempool_unbroadcast.py

2 lines

mining_basic.py

2 lines

mining_prioritisetransaction.py

2 lines

p2p_blockfilters.py

5 lines

p2p_inv_download.py

2 lines

p2p_node_network_limited.py

6 lines

p2p_unrequested_blocks.py

3 lines

rpc_blockchain.py

2 lines

rpc_getblockfilter.py

4 lines

rpc_getchaintips.py

10 lines

rpc_invalidateblock.py

13 lines

rpc_preciousblock.py

16 lines

rpc_txoutproof.py

1 line

test_framework/

avatools.py

21 lines

blocktools.py

6 lines

test_framework.py

18 lines

wallet_abandonconflict.py

3 lines

wallet_balance.py

6 lines

wallet_basic.py

64 lines

wallet_import_rescan.py

2 lines

wallet_importmulti.py

20 lines

wallet_listsinceblock.py

21 lines

wallet_listtransactions.py

1 line

wallet_multiwallet.py

20 lines

wallet_reorgsrestore.py

12 lines

wallet_send.py

1 line

wallet_txn_clone.py

6 lines

wallet_txn_doublespend.py

6 lines

Diff 36372

View Options

test/functional/abc-finalize-block.py

View Options

test/functional/abc-get-invalid-block.py

View Options

test/functional/abc-magnetic-anomaly-mining.py

View Options

test/functional/abc-minimaldata.py

View Options

test/functional/abc-parkedchain.py

View Options

test/functional/abc-schnorr.py

View Options

test/functional/abc-schnorrmultisig.py

View Options

test/functional/abc_feature_minerfund.py

View Options

test/functional/abc_feature_proof_cleanup.py

View Options

test/functional/abc_p2p_avalanche_peer_discovery.py

View Options

test/functional/abc_p2p_avalanche_proof_voting.py

View Options

test/functional/abc_p2p_avalanche_quorum.py

View Options

test/functional/abc_p2p_avalanche_transaction_voting.py

View Options

test/functional/abc_p2p_avalanche_voting.py

View Options

test/functional/abc_p2p_getavaaddr.py

View Options

test/functional/abc_p2p_proof_inventory.py

View Options

test/functional/abc_rpc_addavalanchenode.py

View Options

test/functional/abc_rpc_avalancheproof.py

View Options

test/functional/abc_rpc_buildavalancheproof.py

View Options

test/functional/abc_rpc_getavalancheinfo.py

View Options

test/functional/abc_rpc_getavalanchepeerinfo.py

View Options

test/functional/abc_rpc_getavalancheproofs.py

View Options

test/functional/abc_rpc_isfinal.py

View Options

test/functional/abc_wallet_dumpcoins.py

View Options

test/functional/abc_wallet_standardness.py

View Options

test/functional/example_test.py

View Options

test/functional/feature_abortnode.py

View Options

test/functional/feature_bip68_sequence.py

View Options

test/functional/feature_coinstatsindex.py

View Options

test/functional/feature_dbcrash.py

View Options

test/functional/feature_loadblock.py

View Options

test/functional/feature_minchainwork.py

View Options

test/functional/feature_notifications.py

View Options

test/functional/feature_pruning.py

View Options

test/functional/interface_zmq.py

View Options

test/functional/mempool_persist.py

View Options

test/functional/mempool_reorg.py

View Options

test/functional/mempool_unbroadcast.py

View Options

test/functional/mining_basic.py

View Options

test/functional/mining_prioritisetransaction.py

View Options

test/functional/p2p_blockfilters.py

View Options

test/functional/p2p_inv_download.py

View Options

test/functional/p2p_node_network_limited.py

View Options

test/functional/p2p_unrequested_blocks.py

View Options

test/functional/rpc_blockchain.py

View Options

test/functional/rpc_getblockfilter.py

View Options

test/functional/rpc_getchaintips.py

View Options

test/functional/rpc_invalidateblock.py

View Options

test/functional/rpc_preciousblock.py

View Options

test/functional/rpc_txoutproof.py

View Options

test/functional/test_framework/avatools.py

View Options

test/functional/test_framework/blocktools.py

View Options

test/functional/test_framework/test_framework.py

View Options

test/functional/wallet_abandonconflict.py

View Options

test/functional/wallet_balance.py

View Options

test/functional/wallet_basic.py

View Options

test/functional/wallet_import_rescan.py

View Options

test/functional/wallet_importmulti.py

View Options

test/functional/wallet_listsinceblock.py

View Options

test/functional/wallet_listtransactions.py

View Options

test/functional/wallet_multiwallet.py

View Options

test/functional/wallet_reorgsrestore.py

View Options

test/functional/wallet_send.py

View Options

test/functional/wallet_txn_clone.py

View Options

test/functional/wallet_txn_doublespend.py

test: Implicitly sync after generate*, unless opted outClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36372

test/functional/abc-finalize-block.py

test/functional/abc-get-invalid-block.py

test/functional/abc-magnetic-anomaly-mining.py

test/functional/abc-minimaldata.py

test/functional/abc-parkedchain.py

test/functional/abc-schnorr.py

test/functional/abc-schnorrmultisig.py

test/functional/abc_feature_minerfund.py

test/functional/abc_feature_proof_cleanup.py

test/functional/abc_p2p_avalanche_peer_discovery.py

test/functional/abc_p2p_avalanche_proof_voting.py

test/functional/abc_p2p_avalanche_quorum.py

test/functional/abc_p2p_avalanche_transaction_voting.py

test/functional/abc_p2p_avalanche_voting.py

test/functional/abc_p2p_getavaaddr.py

test/functional/abc_p2p_proof_inventory.py

test/functional/abc_rpc_addavalanchenode.py

test/functional/abc_rpc_avalancheproof.py

test/functional/abc_rpc_buildavalancheproof.py

test/functional/abc_rpc_getavalancheinfo.py

test/functional/abc_rpc_getavalanchepeerinfo.py

test/functional/abc_rpc_getavalancheproofs.py

test/functional/abc_rpc_isfinal.py

test/functional/abc_wallet_dumpcoins.py

test/functional/abc_wallet_standardness.py

test/functional/example_test.py

test/functional/feature_abortnode.py

test/functional/feature_bip68_sequence.py

test/functional/feature_coinstatsindex.py

test/functional/feature_dbcrash.py

test/functional/feature_loadblock.py

test/functional/feature_minchainwork.py

test/functional/feature_notifications.py

test/functional/feature_pruning.py

test/functional/interface_zmq.py

test/functional/mempool_persist.py

test/functional/mempool_reorg.py

test/functional/mempool_unbroadcast.py

test/functional/mining_basic.py

test/functional/mining_prioritisetransaction.py

test/functional/p2p_blockfilters.py

test/functional/p2p_inv_download.py

test/functional/p2p_node_network_limited.py

test/functional/p2p_unrequested_blocks.py

test/functional/rpc_blockchain.py

test/functional/rpc_getblockfilter.py

test/functional/rpc_getchaintips.py

test/functional/rpc_invalidateblock.py

test/functional/rpc_preciousblock.py

test/functional/rpc_txoutproof.py

test/functional/test_framework/avatools.py

test/functional/test_framework/blocktools.py

test/functional/test_framework/test_framework.py

test/functional/wallet_abandonconflict.py

test/functional/wallet_balance.py

test/functional/wallet_basic.py

test/functional/wallet_import_rescan.py

test/functional/wallet_importmulti.py

test/functional/wallet_listsinceblock.py

test/functional/wallet_listtransactions.py

test/functional/wallet_multiwallet.py

test/functional/wallet_reorgsrestore.py

test/functional/wallet_send.py

test/functional/wallet_txn_clone.py

test/functional/wallet_txn_doublespend.py

test: Implicitly sync after generate*, unless opted out
ClosedPublic
Actions

Revision Contents
Changeset List