Differential D12525

[Cashtab][Move msg switch p2] Advanced collapse in Send.js re-titled to Message
ClosedPublic
Actions

Authored by kieran709 on Nov 17 2022, 20:16.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCff0cf3abed48: [Cashtab][Move msg switch p2] Advanced collapse in Send.js re-titled to Message

Summary

Related to T2772. Depends on D12520. Custom msg icon added to CustomIcons, 'Advanced' custom collapse has been renamed to 'CustomIIcon + Message'.

Test Plan

cd web/cashtab && npm start
navigate to Send.js
observe that the title of the 'Advanced' collapse is now 'CustomIcon + Message'

Diff Detail

Repository

rABC Bitcoin ABC

Branch

move-multiple-recipients-switch

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20973
Build 41602: Build Diff	cashtab-tests
Build 41601: arc lint + arc unit

Event Timeline

kieran709 created this revision.Nov 17 2022, 20:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 17 2022, 20:16

kieran709 requested review of this revision.Nov 17 2022, 20:16

Harbormaster completed remote builds in B20973: Diff 36383.Nov 17 2022, 20:19

kieran709 added a child revision: D12536: [Cashtab][Move Msg Switch pt3] Add transition effect to address inputs.Nov 18 2022, 17:54

bytesofman accepted this revision.Nov 19 2022, 15:29

This revision is now accepted and ready to land.Nov 19 2022, 15:29

Closed by commit rABCff0cf3abed48: [Cashtab][Move msg switch p2] Advanced collapse in Send.js re-titled to Message (authored by kieran709). · Explain WhyNov 21 2022, 19:02

This revision was automatically updated to reflect the committed changes.

kieran709 added a commit: rABCff0cf3abed48: [Cashtab][Move msg switch p2] Advanced collapse in Send.js re-titled to Message.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

assets/

mail.svg

1 line

components/

Airdrop/

__tests__/

__snapshots__/

Airdrop.test.js.snap

Common/

CustomIcons.js

9 lines

Configure/

__tests__/

__snapshots__/

Configure.test.js.snap

Home/

__tests__/

__snapshots__/

Home.test.js.snap

Receive/

__tests__/

__snapshots__/

Receive.test.js.snap

Send/

Send.js

14 lines

__tests__/

__snapshots__/

Send.test.js.snap

SendToken.test.js.snap

SignVerifyMsg/

__tests__/

__snapshots__/

SignVerifyMsg.test.js.snap

Tokens/

__tests__/

__snapshots__/

CreateTokenForm.test.js.snap

Tokens.test.js.snap

Diff 36383

View Options

web/cashtab/src/assets/mail.svg

View Options

web/cashtab/src/components/Airdrop/tests/snapshots/Airdrop.test.js.snap

View Options

web/cashtab/src/components/Common/CustomIcons.js

View Options

web/cashtab/src/components/Configure/tests/snapshots/Configure.test.js.snap

View Options

web/cashtab/src/components/Home/tests/snapshots/Home.test.js.snap

View Options

web/cashtab/src/components/Receive/tests/snapshots/Receive.test.js.snap

View Options

web/cashtab/src/components/Send/Send.js

View Options

web/cashtab/src/components/Send/tests/snapshots/Send.test.js.snap

View Options

web/cashtab/src/components/Send/tests/snapshots/SendToken.test.js.snap

View Options

web/cashtab/src/components/SignVerifyMsg/tests/snapshots/SignVerifyMsg.test.js.snap

View Options

web/cashtab/src/components/Tokens/tests/snapshots/CreateTokenForm.test.js.snap

View Options

web/cashtab/src/components/Tokens/tests/snapshots/Tokens.test.js.snap

[Cashtab][Move msg switch p2] Advanced collapse in Send.js re-titled to MessageClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36383

web/cashtab/src/assets/mail.svg

web/cashtab/src/components/Airdrop/__tests__/__snapshots__/Airdrop.test.js.snap

web/cashtab/src/components/Common/CustomIcons.js

web/cashtab/src/components/Configure/__tests__/__snapshots__/Configure.test.js.snap

web/cashtab/src/components/Home/__tests__/__snapshots__/Home.test.js.snap

web/cashtab/src/components/Receive/__tests__/__snapshots__/Receive.test.js.snap

web/cashtab/src/components/Send/Send.js

web/cashtab/src/components/Send/__tests__/__snapshots__/Send.test.js.snap

web/cashtab/src/components/Send/__tests__/__snapshots__/SendToken.test.js.snap

web/cashtab/src/components/SignVerifyMsg/__tests__/__snapshots__/SignVerifyMsg.test.js.snap

web/cashtab/src/components/Tokens/__tests__/__snapshots__/CreateTokenForm.test.js.snap

web/cashtab/src/components/Tokens/__tests__/__snapshots__/Tokens.test.js.snap

[Cashtab][Move msg switch p2] Advanced collapse in Send.js re-titled to Message
ClosedPublic
Actions

Revision Contents
Changeset List

web/cashtab/src/components/Airdrop/tests/snapshots/Airdrop.test.js.snap

web/cashtab/src/components/Configure/tests/snapshots/Configure.test.js.snap

web/cashtab/src/components/Home/tests/snapshots/Home.test.js.snap

web/cashtab/src/components/Receive/tests/snapshots/Receive.test.js.snap

web/cashtab/src/components/Send/tests/snapshots/Send.test.js.snap

web/cashtab/src/components/Send/tests/snapshots/SendToken.test.js.snap

web/cashtab/src/components/SignVerifyMsg/tests/snapshots/SignVerifyMsg.test.js.snap

web/cashtab/src/components/Tokens/tests/snapshots/CreateTokenForm.test.js.snap

web/cashtab/src/components/Tokens/tests/snapshots/Tokens.test.js.snap