Page MenuHomePhabricator

rename Bitcoin to Bitcoin Cash for UI
ClosedPublic

Authored by andychen on Apr 8 2018, 00:47.

Details

Reviewers
jasonbcox
matiu
deadalnix
Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)
Commits
rSTAGINGa8f5955c4915: rename Bitcoin to Bitcoin Cash for UI
rABCa8f5955c4915: rename Bitcoin to Bitcoin Cash for UI
Summary

rename Bitcoin to Bitcoin Cash

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature/UI_words
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2256
Build 2654: Bitcoin ABC Buildbot (legacy)
Build 2653: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Apr 8 2018, 00:47
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptApr 8 2018, 00:47
This revision is now accepted and ready to land.Apr 8 2018, 14:35

some of the Bitcoin is not replaced to Bicoin Cash in locale files, fix it

deadalnix requested changes to this revision.Apr 9 2018, 01:08
deadalnix added a subscriber: deadalnix.

This is way beyoond the scope of the orginal diff. Please revert and make a new diff for the other changes.

This revision now requires changes to proceed.Apr 9 2018, 01:08
This revision was not accepted when it landed; it landed in state Needs Revision.Apr 9 2018, 01:09
This revision was automatically updated to reflect the committed changes.

This is way beyoond the scope of the orginal diff. Please revert and make a new diff for the other changes.

maybe 2 diffs, one for GUI in cpp file & another for all .ts files?

got, some of the Bitcoin should not be replaced to Bitcoin Cash. e.g. Bitcoin ABC