Differential D12552

test: improve rpc_blockchain.py tests and assert on time and mediantime
ClosedPublic
Actions

Authored by Fabien on Nov 21 2022, 12:42.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC8a4c9ccfe3f0: test: improve rpc_blockchain.py tests and assert on time and mediantime

Summary

Backport of core#22520.

Depends on D12551.

Test Plan

./test/functional/test_runner.py rpc_blockchain

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 21 2022, 12:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 21 2022, 12:42

Fabien requested review of this revision.Nov 21 2022, 12:42

teamcity edited the summary of this revision. (Show Details)Nov 21 2022, 12:43

Harbormaster completed remote builds in B21014: Diff 36432.Nov 21 2022, 12:54

Fabien added a child revision: D12554: Remove GetAdjustedTime from init.cpp.Nov 21 2022, 13:00

Wrong PR number.

test/functional/rpc_blockchain.py
139–140 ↗	(On Diff #36432)	There is a change missing here.
489 ↗	(On Diff #36432)

This revision now requires changes to proceed.Nov 21 2022, 15:12

Fabien edited the summary of this revision. (Show Details)Nov 21 2022, 17:30

Feedback

Fabien added inline comments.Nov 21 2022, 17:41

test/functional/rpc_blockchain.py
489 ↗	(On Diff #36432)	Good catch

Harbormaster completed remote builds in B21029: Diff 36452.Nov 21 2022, 18:08

PiRK accepted this revision.Nov 21 2022, 18:37

This revision is now accepted and ready to land.Nov 21 2022, 18:37

Closed by commit rABC8a4c9ccfe3f0: test: improve rpc_blockchain.py tests and assert on time and mediantime (authored by Jon Atack <jon@atack.com>, committed by Fabien). · Explain WhyNov 21 2022, 19:25

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC8a4c9ccfe3f0: test: improve rpc_blockchain.py tests and assert on time and mediantime.

Revision Contents
Changeset List

Path

Size

test/

functional/

rpc_blockchain.py

97 lines

Diff 36461

View Options

test/functional/rpc_blockchain.py

test: improve rpc_blockchain.py tests and assert on time and mediantimeClosedPublicActions