Differential D12548

test: check rejected future block later accepted
ClosedPublic
Actions

Authored by Fabien on Nov 21 2022, 10:54.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC9a316d7679f4: test: check rejected future block later accepted

Summary

(Luke) was unsure if the code sufficiently avoided caching a
time-too-new rejection, so wrote this test to check it.  It looks like despite only exempting BLOCK_MUTATED, it is still okay because header failures never cache block invalidity.  This test will help ensure that if this ever changes, BLOCK_TIME_FUTURE gets excluded at the same time.

Backport of core#22120.

Test Plan

./test/functional/test_runner.py p2p_invalid_block

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 21 2022, 10:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 21 2022, 10:54

Fabien requested review of this revision.Nov 21 2022, 10:54

teamcity edited the summary of this revision. (Show Details)Nov 21 2022, 10:54

Harbormaster completed remote builds in B21008: Diff 36425.Nov 21 2022, 11:12

Fabien added a child revision: D12554: Remove GetAdjustedTime from init.cpp.Nov 21 2022, 13:00

PiRK accepted this revision.Nov 21 2022, 14:56

This revision is now accepted and ready to land.Nov 21 2022, 14:56

Closed by commit rABC9a316d7679f4: test: check rejected future block later accepted (authored by Luke Dashjr <luke-jr+git@utopios.org>, committed by Fabien). · Explain WhyNov 21 2022, 17:27

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC9a316d7679f4: test: check rejected future block later accepted.

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p_invalid_block.py

25 lines

Diff 36449

View Options

test/functional/p2p_invalid_block.py

test: check rejected future block later acceptedClosedPublicActions