[secp256k1] Reduce usage of hardcoded size constant
ClosedPublic
Actions

Authored by deadalnix on Apr 8 2018, 13:49.

Details

Reviewers

matiu
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGeb23540cbc3b: [secp256k1] Reduce usage of hardcoded size constant
rABCeb23540cbc3b: [secp256k1] Reduce usage of hardcoded size constant

Summary

This is backport of PR463 by Thomas Snider

Depends on D1250

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

secpcst

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2257
Build 2656: Bitcoin ABC Buildbot (legacy)
Build 2655: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 8 2018, 13:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 8 2018, 13:49

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

deadalnix retitled this revision from [secp256k1] Reduce usage of hardcoded size constans to [secp256k1] Reduce usage of hardcoded size constant.Apr 8 2018, 13:57

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2257: Diff 3414.Apr 8 2018, 14:12

Nice refactor with 'buffer_append', much clear now.

I was about to suggest to modify 'buffer_append' name to 'buffer_write_at' or something similar, but since offset is moved to the of the written data, I guess append makes sense.

This revision is now accepted and ready to land.Apr 8 2018, 14:45

jasonbcox accepted this revision.Apr 8 2018, 14:46

Closed by commit rABCeb23540cbc3b: [secp256k1] Reduce usage of hardcoded size constant (authored by deadalnix). · Explain WhyApr 8 2018, 14:53

This revision was automatically updated to reflect the committed changes.