Page MenuHomePhabricator

[Cashtab] [BCH deprecation] [TxBuilder] Pt 6/8 - Deprecate BCH.TransactionBuilder in sendToken
ClosedPublic

Authored by emack on Nov 23 2022, 12:08.

Details

Summary

T2730

Depends on D12595

This diff deprecates the use of BCH-JS' transaction builder and replaces it with the local implementation for the sendToken function.

Pt 1/8 - Localize Transaction Builder module
Pt 2/8 - Deprecate BCH.TransactionBuilder in sendXec
Pt 3/8 - Add local TxBuilder to createToken
Pt 4/8 - Deprecate BCH.TransactionBuilder in createToken
Pt 5/8 - Add local TxBuilder to sendToken
Pt 6/8 - Deprecate BCH.TransactionBuilder in sendToken
Pt 7/8 - Add local TxBuilder to burnToken
Pt 8/8 - Deprecate BCH.TransactionBuilder in burnToken

Test Plan

npm ci
npm test and ensure no errors with txBuilder.test.js
npm start
send an existing token and ensure send token tx is successfully broadcasted
send a newly created token and ensure send token tx is successfully broadcasted

Diff Detail

Repository
rABC Bitcoin ABC
Branch
txBuilder2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21089
Build 41832: Build Diffcashtab-tests
Build 41831: arc lint + arc unit