Page MenuHomePhabricator
Differential D12616

[Cashtab] [ECPair from wif p1/3] Add local method
ClosedPublic
Actions

Authored by bytesofman on Nov 25 2022, 09:46.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCb287e872b1fe: [Cashtab] [ECPair from wif p1/3] Add local method
Summary

T2730

Part 1 of a 3-part stacked diff to deprecate BCH.ECPair.fromWIF function

This diff adds a local method, getECPairFromWIF, and compares this method with the existing method in the signUtxosByAddress function

Test Plan

Review new unit test and npm test
npm start, send a transaction, look for local method matches legacy method in the dev log

Diff Detail

Repository
rABC Bitcoin ABC
Branch
local-ecpair-take-two
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21122
Build 41896: Build Diffcashtab-tests
Build 41895: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 25 2022, 09:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2022, 09:46
bytesofman requested review of this revision.Nov 25 2022, 09:46
bytesofman mentioned this in D12488: [Cashtab] [ECPair from wif p1] Add local method.Nov 25 2022, 09:47
Harbormaster completed remote builds in B21122: Diff 36604.Nov 25 2022, 09:49
bytesofman added a child revision: D12618: [Cashtab] [ECPair from wif p2/3] Deprecate BCH method.Nov 25 2022, 09:56
emack accepted this revision.Nov 25 2022, 10:10
This revision is now accepted and ready to land.Nov 25 2022, 10:10
bytesofman updated this revision to Diff 36627.Nov 25 2022, 12:37

rebase

Harbormaster completed remote builds in B21137: Diff 36627.Nov 25 2022, 12:40
Closed by commit rABCb287e872b1fe: [Cashtab] [ECPair from wif p1/3] Add local method (authored by bytesofman). · Explain WhyNov 25 2022, 12:43
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCb287e872b1fe: [Cashtab] [ECPair from wif p1/3] Add local method.
bytesofman added a reverting change: D12630: Revert "[Cashtab] [ECPair from wif p1/3] Add local method".Nov 25 2022, 13:07

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
utils/
__mocks__/
56 lines
__tests__/
7 lines
34 lines

Diff 36604

View Options

web/cashtab/src/utils/__mocks__/mockECPair.js

Loading...
View Options

web/cashtab/src/utils/__tests__/cashMethods.test.js

Loading...
View Options

web/cashtab/src/utils/cashMethods.js

Loading...