Page MenuHomePhabricator

Activate P2SH based on MTP.
ClosedPublic

Authored by deadalnix on Apr 8 2018, 20:00.

Details

Summary

Numerous checks in GetBlockScriptFlags are based on pindex, rather than pindex->prev. This is a problem because only pindex->prev is available when accepting things into the mempool and generally makes the set of flags undecidable from the tip, but require the block being connected.

This changes the time when P2SH activates on testnet, but this isn't that big of a deal because we don't expect a reorg up to 2012 to happen anyway.

Test Plan

Do IBD on etstnet and mainnet.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 9 2018, 03:08
This revision was automatically updated to reflect the committed changes.