Page MenuHomePhabricator
Differential D12629

[Cashtab] [local opreturn encode p1/2] Deprecate BCH.script.encode
ClosedPublic
Actions

Authored by bytesofman on Nov 25 2022, 13:03.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC86a2867a2130: [Cashtab] [local opreturn encode p1/2] Deprecate BCH.script.encode
Summary

T2730

Deprecate BCH.Script.encode

Because this function is already involved in several specific unit tests, and this diff ensures that they still pass, there was no reason to add an intermediate stack comparing the two functions in the dev console.

Test Plan

npm test
npm start and send some encrypted and unencrypted msgs

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Nov 25 2022, 13:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2022, 13:03
bytesofman requested review of this revision.Nov 25 2022, 13:03
bytesofman mentioned this in D12494: [Cashtab] [ECPair from wif p7] Deprecate BCH.script.encode.Nov 25 2022, 13:03
Harbormaster completed remote builds in B21143: Diff 36636.Nov 25 2022, 13:06
bytesofman updated this revision to Diff 36661.Nov 25 2022, 19:12

rebase

bytesofman added a child revision: D12639: [Cashtab] [local opreturn encode p2/2] Simplify function.Nov 25 2022, 19:15
Harbormaster completed remote builds in B21155: Diff 36661.Nov 25 2022, 19:15
emack accepted this revision.Nov 26 2022, 03:17
This revision is now accepted and ready to land.Nov 26 2022, 03:17
bytesofman updated this revision to Diff 36672.Nov 26 2022, 06:25

rebase

This revision was landed with ongoing or failed builds.Nov 26 2022, 06:34
Closed by commit rABC86a2867a2130: [Cashtab] [local opreturn encode p1/2] Deprecate BCH.script.encode (authored by bytesofman). · Explain Why
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC86a2867a2130: [Cashtab] [local opreturn encode p1/2] Deprecate BCH.script.encode.
Harbormaster completed remote builds in B21162: Diff 36672.Nov 26 2022, 07:12

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
1 line
utils/
__tests__/
12 lines
19 lines

Diff 36674

View Options

web/cashtab/src/hooks/useBCH.js

Loading...
View Options

web/cashtab/src/utils/__tests__/cashMethods.test.js

Loading...
View Options

web/cashtab/src/utils/cashMethods.js

Loading...