Page MenuHomePhabricator

[Cashtab] [local opreturn encode p1/2] Deprecate BCH.script.encode
ClosedPublic

Authored by bytesofman on Nov 25 2022, 13:03.

Details

Summary

T2730

Deprecate BCH.Script.encode

Because this function is already involved in several specific unit tests, and this diff ensures that they still pass, there was no reason to add an intermediate stack comparing the two functions in the dev console.

Test Plan

npm test
npm start and send some encrypted and unencrypted msgs

Diff Detail

Repository
rABC Bitcoin ABC
Branch
deprecate-bch-script-encode
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21143
Build 41938: Build Diffcashtab-tests
Build 41937: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Nov 26 2022, 03:17
This revision was landed with ongoing or failed builds.Nov 26 2022, 06:34
This revision was automatically updated to reflect the committed changes.