Paths

Table of Contentst

Differential D12639

[Cashtab] [local opreturn encode p2/2] Simplify function
ClosedPublic
Actions

Authored by bytesofman on Nov 25 2022, 19:14.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC42362d5c2a2b: [Cashtab] [local opreturn encode p2/2] Simplify function

Summary

T2730

Depends on D12629

Remove the ambiguous data variable and simply return the encoded value

Test Plan

npm test
npm start and send an xec tx with an OP_RETURN msg

Diff Detail

Repository

rABC Bitcoin ABC

Branch

deprecate-bch-script-encode

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21156
Build 41964: Build Diff	cashtab-tests
Build 41963: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 25 2022, 19:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2022, 19:14

bytesofman requested review of this revision.Nov 25 2022, 19:14

bytesofman mentioned this in D12495: [Cashtab] [ECPair from wif p8] Simplify function.Nov 25 2022, 19:15

bytesofman edited the summary of this revision. (Show Details)

bytesofman added a parent revision: D12629: [Cashtab] [local opreturn encode p1/2] Deprecate BCH.script.encode.

Harbormaster completed remote builds in B21156: Diff 36662.Nov 25 2022, 19:18

emack accepted this revision.Nov 26 2022, 03:33

This revision is now accepted and ready to land.Nov 26 2022, 03:33

rebase

This revision was landed with ongoing or failed builds.Nov 26 2022, 06:35

Closed by commit rABC42362d5c2a2b: [Cashtab] [local opreturn encode p2/2] Simplify function (authored by bytesofman). · Explain Why

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC42362d5c2a2b: [Cashtab] [local opreturn encode p2/2] Simplify function.

Harbormaster completed remote builds in B21163: Diff 36673.Nov 26 2022, 06:44

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

utils/

cashMethods.js

4 lines

Diff 36662

View Options

web/cashtab/src/utils/cashMethods.js

[Cashtab] [local opreturn encode p2/2] Simplify functionClosedPublicActions