Page MenuHomePhabricator
Differential D12671

[Cashtab] [deprecate BCH from token send p1] Remove BCH param from generateTokenTxInput
ClosedPublic
Actions

Authored by bytesofman on Nov 28 2022, 08:22.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC09cb6245f9af: [Cashtab] [deprecate BCH from token send p1] Remove BCH param from…
Summary

T2730

Stack to deprecate BCH param from token tx functions

p1, remove BCH param from generateTokenTxInput

Test Plan

grep -r generateTokenTxInput and make sure BCH is removed from all called instances
npm test
npm start and send a token tx, burn a token, mint a token

Diff Detail

Repository
rABC Bitcoin ABC
Branch
deprecate-bch-from-sendtoken
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21213
Build 42078: Build Diffcashtab-tests
Build 42077: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 28 2022, 08:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 28 2022, 08:22
bytesofman requested review of this revision.Nov 28 2022, 08:22
bytesofman added a comment.Nov 28 2022, 08:24

Need to wait on D12668 stack to land for this, or build this on top of that stack -- since that stack removes the BCH param from signAndBuildTx

Harbormaster completed remote builds in B21213: Diff 36739.Nov 28 2022, 08:25
bytesofman updated this revision to Diff 36772.Nov 29 2022, 09:52

rebase

Harbormaster completed remote builds in B21237: Diff 36772.Nov 29 2022, 10:03
bytesofman updated this revision to Diff 36787.Nov 29 2022, 16:05

rebase

Harbormaster completed remote builds in B21243: Diff 36787.Nov 29 2022, 16:12
bytesofman added a child revision: D12690: [Cashtab] [deprecate BCH from token send p2] Remove from Send, Burn, and SendToken.Nov 29 2022, 16:13
emack accepted this revision.Nov 29 2022, 23:12
This revision is now accepted and ready to land.Nov 29 2022, 23:12
Closed by commit rABC09cb6245f9af: [Cashtab] [deprecate BCH from token send p1] Remove BCH param from… (authored by bytesofman). · Explain WhyNov 30 2022, 07:44
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC09cb6245f9af: [Cashtab] [deprecate BCH from token send p1] Remove BCH param from….

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
3 lines
utils/
__tests__/
6 lines
2 lines

Diff 36739

View Options

web/cashtab/src/hooks/useBCH.js

Loading...
View Options

web/cashtab/src/utils/__tests__/cashMethods.test.js

Loading...
View Options

web/cashtab/src/utils/cashMethods.js

Loading...