Page MenuHomePhabricator
Differential D12704

[net processing] Remove CNodeState.nBlocksInFlightValidHeaders
ClosedPublic
Actions

Authored by PiRK on Nov 30 2022, 16:30.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABCc20d44ebfa7a: [net processing] Remove CNodeState.nBlocksInFlightValidHeaders
Summary

nBlocksInFlightValidHeaders always has the same value as nBlocksInFlight, since we only download
blocks with valid headers.

This is a partial backport of core#22141
https://github.com/bitcoin/bitcoin/pull/22141/commits/b03de9c7538d85b12929a62b9ec966fd3910e660

Depends on D12703

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 30 2022, 16:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2022, 16:30
PiRK requested review of this revision.Nov 30 2022, 16:30
teamcity edited the summary of this revision. (Show Details)Nov 30 2022, 16:30
PiRK added inline comments.Nov 30 2022, 16:33
src/net_processing.cpp
6933 ↗(On Diff #36834)

Note for reviewers: this is because nBlocksInFlightValidHeaders is always incremented together with vBlocksInFlight, so state.vBlocksInFlight.size() > 0 implies state.nBlocksInFlightValidHeaders > 0

PiRK added a child revision: D12706: scripted-diff: rename nPeersWithValidatedDownloads.Nov 30 2022, 16:34
Harbormaster completed remote builds in B21279: Diff 36834.Nov 30 2022, 17:07
sdulfari accepted this revision.Nov 30 2022, 17:16
This revision is now accepted and ready to land.Nov 30 2022, 17:16
Closed by commit rABCc20d44ebfa7a: [net processing] Remove CNodeState.nBlocksInFlightValidHeaders (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain WhyDec 1 2022, 07:46
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCc20d44ebfa7a: [net processing] Remove CNodeState.nBlocksInFlightValidHeaders.

Revision Contents
Changeset List

PathSize
src/
21 lines

Diff 36854

View Options

src/net_processing.cpp

Loading...