Differential D1271

Compute script flags based on the chain tip rather than the block we are connecting.
ClosedPublic
Actions

Authored by deadalnix on Apr 9 2018, 15:40.

Details

Reviewers

schancel

Group Reviewers

Restricted Project

Maniphest Tasks

T288: GetBlockScriptFlags usage is inconsistent between mempool and block validation

Commits

rSTAGINGd011b7867284: Compute script flags based on the chain tip rather than the block we are…
rABCd011b7867284: Compute script flags based on the chain tip rather than the block we are…

Summary

This fixes T288 and ensures that flags are consistent when accepting new block and when accepting txns in the mempool without having to build extra piping.

Test Plan

make check

Do IBD on mainnet and testnet

Diff Detail

Repository

rABC Bitcoin ABC

Branch

scriptflagtip

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2281
Build 2700: Bitcoin ABC Buildbot (legacy)
Build 2699: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 9 2018, 15:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 9 2018, 15:40

schancel accepted this revision.Apr 9 2018, 15:47

This revision is now accepted and ready to land.Apr 9 2018, 15:47

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2281: Diff 3458.Apr 9 2018, 19:21

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Closed by commit rABCd011b7867284: Compute script flags based on the chain tip rather than the block we are… (authored by deadalnix). · Explain WhyApr 9 2018, 22:34

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

45 lines

Diff 3458

View Options

Compute script flags based on the chain tip rather than the block we are connecting.ClosedPublicActions