Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC1b4b9bf33b47: [Cashtab] [Remove BCH param from wallet derivation p1] Remove use of slpAddress…

Summary

T2836

Remove use of legacy address types from Cashtab as prep for removing them from wallet object

Currently, only wallet.Path1899.slpAddress is used anywhere in the app. Remove it.

Test Plan

npm start
Send an airdrop with 'Ignore my own address' checked
Confirm it ignores your address
grep -r wallet.Path1899.slpAddress src/ and no result
grep -r wallet.Path1899.legacyAddress src/ and no result
grep -r wallet.Path1899.fundingAddress src/ and no result

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Dec 4 2022, 11:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 4 2022, 11:32

bytesofman requested review of this revision.Dec 4 2022, 11:32

bytesofman mentioned this in D12722: [Cashtab] Remove BCH param from wallet derivation.Dec 4 2022, 11:33

Harbormaster completed remote builds in B21347: Diff 36947.Dec 4 2022, 11:36

bytesofman added a child revision: D12750: [Cashtab] [Remove BCH param from wallet derivation p2] Deprecate BCH param from deriveWallet.Dec 4 2022, 11:43

emack requested changes to this revision.Dec 4 2022, 12:22

emack added a subscriber: emack.

emack added inline comments.

web/cashtab/src/components/Airdrop/Airdrop.js
244 ↗	(On Diff #36947)	The problem with changing it to cashAddress above is that the airdropList array (outputs from eToken-list library) contains etoken addresses (not ecash: ), therefore it fails to find the corresponding etoken address to delete from the array. Would suggest getting rid of `ownEtokenAddress` altogether since it's only used here, and to do something like: if (ignoreOwnAddress) { airdropList.delete( convertEcashtoEtokenAddr( ownEcashAddress ) ); }