Page MenuHomePhabricator
Differential D12750

[Cashtab] [Remove BCH param from wallet derivation p2] Deprecate BCH param from deriveWallet
ClosedPublic
Actions

Authored by bytesofman on Dec 4 2022, 11:43.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC2a29b33fb58f: [Cashtab] [Remove BCH param from wallet derivation p2] Deprecate BCH param from…
Summary

T2836

Depends on D12749

Stop creating fundingAddress, legacyAddress, and slpAddress fields in the deriveAccount function.

This deprecates the BCH param from deriveAccount. Since BCH param is only used in migrateLegacyWallet to call deriveAccount, this also deprecates the BCH param from migrateLegacyWallet

Note: This diff will not cause existing wallets to fail isLegacyMigrationRequired, therefore it will not force migration. Existing wallets will not have legacyAddress, fundingAddress, and slpAddress deleted. This diff only impacts the creation of new wallets.

When we change wallet structure later and migration is required, migrated wallets will be created without these legacy address types.

Test Plan

npm start
Create a new wallet
Note that it is created without slpAddress, legacyAddress, or fundingAddress
Activate it
Send an XEC tx

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Dec 4 2022, 11:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 4 2022, 11:43
bytesofman requested review of this revision.Dec 4 2022, 11:43
bytesofman added a child revision: D12751: [Cashtab] [Remove BCH param from wallet derivation p3/3] Delete unused mocks.Dec 4 2022, 11:46
Harbormaster completed remote builds in B21348: Diff 36948.Dec 4 2022, 11:46
emack accepted this revision.Dec 4 2022, 12:31
This revision is now accepted and ready to land.Dec 4 2022, 12:31
bytesofman updated this revision to Diff 36960.Dec 4 2022, 14:02

rebase

Harbormaster completed remote builds in B21359: Diff 36960.Dec 4 2022, 14:04
bytesofman updated this revision to Diff 36971.Dec 5 2022, 00:05

rebase

Harbormaster completed remote builds in B21370: Diff 36971.Dec 5 2022, 00:08
Closed by commit rABC2a29b33fb58f: [Cashtab] [Remove BCH param from wallet derivation p2] Deprecate BCH param from… (authored by bytesofman). · Explain WhyDec 5 2022, 00:11
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC2a29b33fb58f: [Cashtab] [Remove BCH param from wallet derivation p2] Deprecate BCH param from….

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
__mocks__/
15 lines
__tests__/
2 lines
27 lines

Diff 36974

View Options

web/cashtab/src/hooks/__mocks__/mockLegacyWallets.js

Loading...
View Options

web/cashtab/src/hooks/__tests__/useWallet.test.js

Loading...
View Options

web/cashtab/src/hooks/useWallet.js

Loading...