HomePhabricator

[Cashtab] [Remove BCH param from wallet derivation p2] Deprecate BCH param from…

Description

[Cashtab] [Remove BCH param from wallet derivation p2] Deprecate BCH param from deriveWallet

Summary:
T2836

Depends on D12749

Stop creating fundingAddress, legacyAddress, and slpAddress fields in the deriveAccount function.

This deprecates the BCH param from deriveAccount. Since BCH param is only used in migrateLegacyWallet to call deriveAccount, this also deprecates the BCH param from migrateLegacyWallet

Note: This diff will not cause existing wallets to fail isLegacyMigrationRequired, therefore it will not force migration. Existing wallets will not have legacyAddress, fundingAddress, and slpAddress deleted. This diff only impacts the creation of new wallets.

When we change wallet structure later and migration is required, migrated wallets will be created without these legacy address types.

Test Plan:
npm start
Create a new wallet
Note that it is created without slpAddress, legacyAddress, or fundingAddress
Activate it
Send an XEC tx

Reviewers: #bitcoin_abc, emack

Reviewed By: #bitcoin_abc, emack

Differential Revision: https://reviews.bitcoinabc.org/D12750

Details

Provenance
bytesofmanAuthored on Dec 4 2022, 11:40
bytesofmanPushed on Dec 5 2022, 00:11
Reviewer
Restricted Project
Differential Revision
D12750: [Cashtab] [Remove BCH param from wallet derivation p2] Deprecate BCH param from deriveWallet
Parents
rABC1b4b9bf33b47: [Cashtab] [Remove BCH param from wallet derivation p1] Remove use of slpAddress…
Branches
Unknown
Tags
Unknown