Paths

Table of Contentst

Differential D12763

Add src/node/* code to node:: namespace
ClosedPublic
Actions

Authored by PiRK on Dec 5 2022, 11:13.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCe1fa92adeb2d: Add src/node/* code to node:: namespace

Summary

Overall PR:

There are no code changes, this is just adding namespace and using declarations and node:: or wallet:: qualifiers in some places.

Motivations for this change are:

To make it easier to see when node and wallet code is being accessed places where it shouldn't be. For example if GUI code is accessing node and wallet internals or if wallet and node code are referencing each other.

To make source code organization clearer (core#15732), being able to know that wallet:: code is in src/wallet/, node:: code is in src/node/, init:: code is in src/init/, util:: code is in src/util/, etc.

Notes:

CBlockIndexWorkComparator is not part of the node namespace for Bitcoin ABC because it is defined in its own header file rather than src/node/blockstorage.h
some fuzzers and minisketchwrapper.* changes are not applicable due to missing backports (see core#23114).

This is a partial backport of core#23497
https://github.com/bitcoin/bitcoin/pull/23497/commits/90fc8b089d591cabff60ee829a33f96c37fd27ba

Test Plan

ninja all check-all bitcoin-fuzzers bench-bitcoin

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 5 2022, 11:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 5 2022, 11:13

PiRK requested review of this revision.Dec 5 2022, 11:13

teamcity edited the summary of this revision. (Show Details)Dec 5 2022, 11:13

PiRK edited the summary of this revision. (Show Details)Dec 5 2022, 11:19

PiRK edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B21379: Diff 36990.Dec 5 2022, 11:29

Fabien accepted this revision.Dec 5 2022, 12:31

This revision is now accepted and ready to land.Dec 5 2022, 12:31

Closed by commit rABCe1fa92adeb2d: Add src/node/* code to node:: namespace (authored by Russell Yanofsky <russ@yanofsky.org>, committed by PiRK). · Explain WhyDec 5 2022, 12:39

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCe1fa92adeb2d: Add src/node/* code to node:: namespace.

PiRK mentioned this in D12764: [chronik] use the node:: namespace for NodeContext.Dec 5 2022, 14:17

PiRK mentioned this in rABC8f5febde21ec: [chronik] use the node:: namespace for NodeContext.Dec 5 2022, 14:34

Revision Contents
Changeset List

Path

Size

src/

bench/

coin_selection.cpp

2 lines

2 lines

dummywallet.cpp

2 lines

index/

2 lines

blockfilterindex.cpp

2 lines

coinstatsindex.h

2 lines

coinstatsindex.cpp

6 lines

2 lines

14 lines

15 lines

init/

2 lines

interfaces/

5 lines

10 lines

net_processing.cpp

5 lines

node/

2 lines

blockstorage.cpp

4 lines

2 lines

2 lines

6 lines

2 lines

3 lines

2 lines

9 lines

2 lines

2 lines

2 lines

13 lines

3 lines

2 lines

2 lines

2 lines

5 lines

transaction.cpp

2 lines

utxo_snapshot.h

2 lines

qt/

2 lines

test/

2 lines

4 lines

5 lines

rpc/

3 lines

4 lines

18 lines

6 lines

2 lines

2 lines

rawtransaction.cpp

9 lines

12 lines

server_util.cpp

2 lines

test/

blockfilter_index_tests.cpp

4 lines

coinstatsindex_tests.cpp

3 lines

fuzz/

4 lines

deserialize.cpp

2 lines

4 lines

miner_tests.cpp

5 lines

util/

blockfilter.cpp

3 lines

6 lines

9 lines

3 lines

4 lines

setup_common.cpp

8 lines

validation_block_tests.cpp

2 lines

validation_chainstatemanager_tests.cpp

2 lines

validation_flush_tests.cpp

2 lines

20 lines

18 lines

wallet/

2 lines

test/

coinselector_tests.cpp

2 lines

wallet_tests.cpp

3 lines

walletdb_tests.cpp

2 lines

walletinitinterface.h

4 lines

zmq/

zmqpublishnotifier.cpp

2 lines

Diff 36999

src/bench/coin_selection.cpp

Loading...

src/bitcoind.cpp

Loading...

src/dummywallet.cpp

Loading...

src/index/base.cpp

Loading...

src/index/blockfilterindex.cpp

Loading...

src/index/coinstatsindex.h

Loading...

src/index/coinstatsindex.cpp

Loading...

src/index/txindex.cpp

Loading...

src/init.h

Loading...

src/init.cpp

Loading...

src/init/common.cpp

Loading...

src/interfaces/chain.h

Loading...

src/interfaces/node.h

Loading...

src/net_processing.cpp

Loading...

src/node/blockstorage.h

Loading...

src/node/blockstorage.cpp

Loading...

src/node/caches.h

Loading...

src/node/caches.cpp

Loading...

src/node/chainstate.h

Loading...

src/node/chainstate.cpp

Loading...

src/node/coin.h

Loading...

src/node/coin.cpp

Loading...

src/node/coinstats.h

Loading...

src/node/coinstats.cpp

Loading...

src/node/context.h

Loading...

src/node/context.cpp

Loading...

src/node/interfaces.cpp

Loading...

src/node/miner.h

Loading...

src/node/miner.cpp

Loading...

src/node/psbt.h

Loading...

src/node/psbt.cpp

Loading...

src/node/transaction.h

Loading...

src/node/transaction.cpp

Loading...

src/node/utxo_snapshot.h

Loading...

src/qt/bitcoin.cpp

Loading...

src/qt/test/test_main.cpp

Loading...

src/qt/walletview.cpp

Loading...

src/rest.cpp

Loading...

src/rpc/avalanche.cpp

Loading...

src/rpc/blockchain.h

Loading...

src/rpc/blockchain.cpp

Loading...

src/rpc/mining.cpp

Loading...

src/rpc/misc.cpp

Loading...

src/rpc/net.cpp

Loading...

src/rpc/rawtransaction.cpp

Loading...

src/rpc/server_util.h

Loading...

src/rpc/server_util.cpp

Loading...

src/test/blockfilter_index_tests.cpp

Loading...

src/test/coinstatsindex_tests.cpp

Loading...

src/test/fuzz/coins_view.cpp

Loading...

src/test/fuzz/deserialize.cpp

Loading...

src/test/fuzz/psbt.cpp

Loading...

src/test/miner_tests.cpp

Loading...

src/test/util/blockfilter.cpp

Loading...

src/test/util/chainstate.h

Loading...

src/test/util/mining.h

Loading...

src/test/util/mining.cpp

Loading...

src/test/util/setup_common.h

Loading...

src/test/util/setup_common.cpp

Loading...

src/test/validation_block_tests.cpp

Loading...

src/test/validation_chainstatemanager_tests.cpp

Loading...

src/test/validation_flush_tests.cpp

Loading...

src/validation.h

Loading...

src/validation.cpp

Loading...

src/wallet/init.cpp

Loading...

src/wallet/test/coinselector_tests.cpp

Loading...

src/wallet/test/wallet_tests.cpp

Loading...

src/wallet/test/walletdb_tests.cpp

Loading...

src/walletinitinterface.h

Loading...

src/zmq/zmqpublishnotifier.cpp

Loading...