Differential D12790

Rename the remaining sigOps to sigChecks
ClosedPublic
Actions

Authored by Fabien on Dec 7 2022, 14:45.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC7ef742b6544f: Rename the remaining sigOps to sigChecks

Summary

Similar to D12787, the only remaining sigOps are from the options and RPCs in order to not break compatibility.

Depends on D12787.

Test Plan

ninja all check-all
ninja bitcoin-fuzzers

Diff Detail

Repository

rABC Bitcoin ABC

Branch

sigchecks_misc

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21429
Build 42508: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang · build-bench
Build 42507: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 7 2022, 14:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 7 2022, 14:45

Fabien requested review of this revision.Dec 7 2022, 14:45

Harbormaster completed remote builds in B21422: Diff 37054.Dec 7 2022, 15:01

Rebase

Harbormaster completed remote builds in B21429: Diff 37065.Dec 7 2022, 16:45

sdulfari accepted this revision.Dec 7 2022, 19:10

This revision is now accepted and ready to land.Dec 7 2022, 19:10

Closed by commit rABC7ef742b6544f: Rename the remaining sigOps to sigChecks (authored by Fabien). · Explain WhyDec 7 2022, 20:05

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC7ef742b6544f: Rename the remaining sigOps to sigChecks.

Revision Contents
Changeset List

Path

Size

src/

bench/

4 lines

4 lines

2 lines

2 lines

11 lines

2 lines

rpc/

mining.cpp

10 lines

validation.cpp

5 lines

Diff 37065

View Options

src/bench/mempool_eviction.cpp

View Options

src/bench/mempool_stress.cpp

View Options

src/bench/rpc_mempool.cpp

View Options

src/blockvalidity.h

View Options

src/init.cpp

View Options

src/net_processing.cpp

View Options

src/rpc/mining.cpp

View Options

Rename the remaining sigOps to sigChecksClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37065

src/bench/mempool_eviction.cpp

src/bench/mempool_stress.cpp

src/bench/rpc_mempool.cpp

src/blockvalidity.h

src/init.cpp

src/net_processing.cpp

src/rpc/mining.cpp

src/validation.cpp

Rename the remaining sigOps to sigChecks
ClosedPublic
Actions

Revision Contents
Changeset List