[Part 1] Refactor logging code into a global object
ClosedPublic
Actions

Authored by jimpo on Apr 12 2018, 19:03.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGce400ab43c46: [Part 1] Refactor logging code into a global object
rABCce400ab43c46: [Part 1] Refactor logging code into a global object

Summary

MOVEONLY: Move logging code from util.{h,cpp} to new files.

Break logging code out of util.{h,cpp} into logging.{h,cpp}. This does not modify anything, just moves code.

Test Plan

Run bitcoind with different permutations of:
-logtimestamps, -debug, -printtoconsole, -datadir, -shrinkdebugfile

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2302
Build 2742: Bitcoin ABC Buildbot (legacy)
Build 2741: arc lint + arc unit

Event Timeline

jimpo created this revision.Apr 12 2018, 19:03

Owners added a reviewer: Restricted Owners Package.Apr 12 2018, 19:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 12 2018, 19:03

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2296: Diff 3481.Apr 12 2018, 19:27

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

jimpo added a child revision: D1281: [Part 2] Refactor logging code into a global object.Apr 12 2018, 19:36

jimpo retitled this revision from MOVEONLY: Move logging code from util.{h,cpp} to new files. to [Part 1] Refactor logging code into a global object.Apr 12 2018, 19:43

jimpo edited the summary of this revision. (Show Details)

Few small change, but overall, looks good.

src/logging.cpp
2 ↗	(On Diff #3481)	// Copyright (c) 2009-2016 The Bitcoin Core developers As per the copyright mention in the file it was extracted from.
3 ↗	(On Diff #3481)	// Copyright (c) 2017-2018 The Bitcoin developers
src/logging.h
3 ↗	(On Diff #3481)	See comment in the cpp file.
src/util.h
63 ↗	(On Diff #3481)	Why the change ?

This revision now requires changes to proceed.Apr 12 2018, 20:07

jimpo added inline comments.Apr 12 2018, 20:11

src/util.h
63 ↗	(On Diff #3481)	Because LogPrintStr will be moved out of the global scope in a later commit. I will revert the change to this one and update the child diff.