Related to T2870. Added flex ctn to cashtab logo in the extension to fix issue with the popout button appearing below the logo & nav indicators.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project
cd web/cashtab && npm run extension
wait for extension to build
in your browser's extension manager:
click load unpacked
navigate to /extension and select the /dist dir
open the extension
observe that the popout button is now flexed with the cashtab logo
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- patch-popout-placement-extn
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 21556 Build 42754: Build Diff cashtab-tests Build 42753: arc lint + arc unit
Event Timeline
Comment Actions
I'm not able to arc patch this one, maybe this was built on top of the wrong branch? Looks like D12876 was on master, I've made that mistake before. Without correcting, any other diff you make "on master" is not on the right master.
To correct,
git checkout master git reset --hard origin/master