Differential D12880

[Cashtab][extn] fix placement of popout button in extension
ClosedPublic
Actions

Authored by kieran709 on Dec 13 2022, 00:48.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCddc832222723: [Cashtab][extn] fix placement of popout button in extension

Summary

Related to T2870. Added flex ctn to cashtab logo in the extension to fix issue with the popout button appearing below the logo & nav indicators.

Test Plan

cd web/cashtab && npm run extension
wait for extension to build
in your browser's extension manager:
click load unpacked
navigate to /extension and select the /dist dir
open the extension
observe that the popout button is now flexed with the cashtab logo

Diff Detail

Repository

rABC Bitcoin ABC

Branch

patch-popout-placement-extn

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21557
Build 42756: Build Diff	cashtab-tests
Build 42755: arc lint + arc unit

Event Timeline

kieran709 created this revision.Dec 13 2022, 00:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 13 2022, 00:48

kieran709 requested review of this revision.Dec 13 2022, 00:48

Harbormaster completed remote builds in B21557: Diff 37249.Dec 13 2022, 00:51

image.png (246×399 px, 13 KB)

We still want the "Cashtab" logo to be centered.

Placement of the "open in new tab" link is correct here.

This revision now requires changes to proceed.Dec 13 2022, 01:33

Responding to review feedback

Harbormaster completed remote builds in B21568: Diff 37263.Dec 13 2022, 19:51

bytesofman accepted this revision.Dec 13 2022, 21:59

This revision is now accepted and ready to land.Dec 13 2022, 21:59

Closed by commit rABCddc832222723: [Cashtab][extn] fix placement of popout button in extension (authored by kieran709). · Explain WhyDec 14 2022, 16:36

This revision was automatically updated to reflect the committed changes.

kieran709 added a commit: rABCddc832222723: [Cashtab][extn] fix placement of popout button in extension.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

extension/

src/

components/

30 lines

Diff 37249

web/cashtab/extension/src/components/App.js

Loading...