Page MenuHomePhabricator

[Cashtab][extn] fix placement of popout button in extension
ClosedPublic

Authored by kieran709 on Dec 13 2022, 00:48.

Details

Summary

Related to T2870. Added flex ctn to cashtab logo in the extension to fix issue with the popout button appearing below the logo & nav indicators.

Test Plan

cd web/cashtab && npm run extension
wait for extension to build
in your browser's extension manager:
click load unpacked
navigate to /extension and select the /dist dir
open the extension
observe that the popout button is now flexed with the cashtab logo

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch-popout-placement-extn
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21568
Build 42778: Build Diffcashtab-tests
Build 42777: arc lint + arc unit

Event Timeline

image.png (246×399 px, 13 KB)

We still want the "Cashtab" logo to be centered.

Placement of the "open in new tab" link is correct here.

This revision now requires changes to proceed.Dec 13 2022, 01:33

Responding to review feedback

This revision is now accepted and ready to land.Dec 13 2022, 21:59