Page MenuHomePhabricator
Differential D12886

[avalanche] Optimize block parking
ClosedPublic
Actions

Authored by sdulfari on Dec 13 2022, 18:44.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3074dd676c26: [avalanche] Optimize block parking
Summary

Leverage the avalanche finalized block index to park blocks. This will allow us to remove -parkdeepreorg
in the future.

Depends on D12885

Test Plan
ninja check check-functional

Diff Detail

Event Timeline

sdulfari created this revision.Dec 13 2022, 18:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 13 2022, 18:44
sdulfari edited the summary of this revision. (Show Details)Dec 13 2022, 18:45
sdulfari added a parent revision: D12885: [avalanche] Clear finalization when manually switching chaintips.
Harbormaster completed remote builds in B21564: Diff 37259.Dec 13 2022, 18:45
teamcity added a comment.Dec 13 2022, 18:45
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[369/535] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[370/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[371/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[372/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[373/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[374/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[375/535] Linking C executable src/secp256k1/recover-bench
[376/535] Installing component secp256k1
-- Install configuration: "RelWithDebInfo"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[377/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[378/535] Linking C executable src/secp256k1/verify-bench
[379/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[380/535] Linking C executable src/secp256k1/ecmult-bench
[381/535] Linking C executable src/secp256k1/sign-bench
[382/535] Linking C executable src/secp256k1/internal-bench
[383/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[384/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[385/535] Linking CXX static library src/libcommon.a
[386/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[387/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[388/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[389/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[390/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[391/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[392/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[393/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[394/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[395/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[396/535] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[397/535] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[398/535] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[399/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[400/535] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[401/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[402/535] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[403/535] Linking CXX static library src/libscript.a
[404/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[405/535] Linking CXX static library src/libbitcoinconsensus.a
[406/535] Linking CXX shared library src/libbitcoinconsensus.so.0.26.8
[407/535] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[408/535] Linking CXX executable src/bitcoin-cli
[409/535] Linking CXX executable src/bitcoin-tx
[410/535] Linking CXX static library src/wallet/libwallet.a
[411/535] Linking CXX static library src/wallet/libwallet-tool.a
[412/535] Linking CXX executable src/bitcoin-wallet
[413/535] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
FAILED: src/CMakeFiles/server.dir/validation.cpp.o 
/usr/bin/ccache /usr/bin/clang++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_ALL_NO_LIB -DBOOST_ATOMIC_DYN_LINK -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_SP_USE_STD_ATOMIC -DBOOST_THREAD_DYN_LINK -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/validation.cpp.o -MF src/CMakeFiles/server.dir/validation.cpp.o.d -o src/CMakeFiles/server.dir/validation.cpp.o -c ../../src/validation.cpp
../../src/validation.cpp:3744:1: error: non-void function does not return a value [-Werror,-Wreturn-type]
}
^
1 error generated.
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
teamcity added a comment.Dec 13 2022, 18:46
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

[363/535] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[364/535] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[365/535] Linking CXX executable src/bitcoin-cli
[366/535] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[367/535] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[368/535] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[369/535] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[370/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[371/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[372/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[373/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[374/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[375/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[376/535] Linking CXX executable src/bitcoin-tx
[377/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[378/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[379/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[380/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[381/535] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[382/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[383/535] Building CXX object src/CMakeFiles/server.dir/txorphanage.cpp.o
[384/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[385/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[386/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[387/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[388/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[389/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[390/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[391/535] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[392/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[393/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[394/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[395/535] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[396/535] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[397/535] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[398/535] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[399/535] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[400/535] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[401/535] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[402/535] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[403/535] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[404/535] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[405/535] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[406/535] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
FAILED: src/CMakeFiles/server.dir/validation.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DABORT_ON_FAILED_ASSUME -DBOOST_AC_USE_STD_ATOMIC -DBOOST_ALL_NO_LIB -DBOOST_ATOMIC_DYN_LINK -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_SP_USE_STD_ATOMIC -DBOOST_THREAD_DYN_LINK -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -O0 -fPIC -fvisibility=hidden -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/validation.cpp.o -MF src/CMakeFiles/server.dir/validation.cpp.o.d -o src/CMakeFiles/server.dir/validation.cpp.o -c ../../src/validation.cpp
../../src/validation.cpp: In member function ‘bool CChainState::ClearAvalancheFinalizedBlock()’:
../../src/validation.cpp:3744:1: error: no return statement in function returning non-void [-Werror=return-type]
 3744 | }
      | ^
cc1plus: all warnings being treated as errors
[407/535] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[408/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[409/535] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[410/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[411/535] Linking CXX static library src/wallet/libwallet.a
[412/535] Linking CXX static library src/wallet/libwallet-tool.a
[413/535] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
teamcity added a comment.Dec 13 2022, 18:46
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

[334/475] Building CXX object src/CMakeFiles/server.dir/rest.cpp.o
[335/475] Building CXX object src/CMakeFiles/server.dir/validationinterface.cpp.o
[336/475] Building CXX object src/CMakeFiles/server.dir/versionbits.cpp.o
[337/475] Building CXX object src/CMakeFiles/server.dir/dummywallet.cpp.o
[338/475] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[339/475] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[340/475] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[341/475] Linking C static library src/secp256k1/libsecp256k1.a
[342/475] Building CXX object src/CMakeFiles/server.dir/script/scriptcache.cpp.o
[343/475] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[344/475] Linking C executable src/secp256k1/recover-bench
[345/475] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[346/475] Linking CXX static library src/libscript.a
[347/475] Linking C executable src/secp256k1/ecmult-bench
[348/475] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[349/475] Linking CXX static library src/libbitcoinconsensus.a
[350/475] Linking C executable src/secp256k1/verify-bench
[351/475] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[352/475] Linking C executable src/secp256k1/sign-bench
[353/475] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[354/475] Linking C executable src/secp256k1/internal-bench
[355/475] Linking CXX static library src/libcommon.a
[356/475] Linking CXX shared library src/libbitcoinconsensus.so.0.26.8
[357/475] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[358/475] Linking CXX executable src/bitcoin-cli
[359/475] Linking CXX executable src/bitcoin-tx
[360/475] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[361/475] Building CXX object src/CMakeFiles/server.dir/net.cpp.o
[362/475] Building CXX object src/CMakeFiles/server.dir/txorphanage.cpp.o
[363/475] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[364/475] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[365/475] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[366/475] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[367/475] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[368/475] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[369/475] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[370/475] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[371/475] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[372/475] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[373/475] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[374/475] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[375/475] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[376/475] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[377/475] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[378/475] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[379/475] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[380/475] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[381/475] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[382/475] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
FAILED: src/CMakeFiles/server.dir/validation.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_ALL_NO_LIB -DBOOST_ATOMIC_DYN_LINK -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_SP_USE_STD_ATOMIC -DBOOST_THREAD_DYN_LINK -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/validation.cpp.o -MF src/CMakeFiles/server.dir/validation.cpp.o.d -o src/CMakeFiles/server.dir/validation.cpp.o -c ../../src/validation.cpp
../../src/validation.cpp: In member function ‘bool CChainState::ClearAvalancheFinalizedBlock()’:
../../src/validation.cpp:3744:1: error: no return statement in function returning non-void [-Werror=return-type]
 3744 | }
      | ^
cc1plus: all warnings being treated as errors
[383/475] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[384/475] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1
teamcity added a comment.Dec 13 2022, 18:46
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[363/535] Building CXX object src/CMakeFiles/server.dir/txorphanage.cpp.o
[364/535] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[365/535] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[366/535] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[367/535] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[368/535] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[369/535] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[370/535] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[371/535] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[372/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[373/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[374/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[375/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[376/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[377/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[378/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[379/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[380/535] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[381/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[382/535] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[383/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[384/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[385/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[386/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[387/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[388/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[389/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[390/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[391/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[392/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[393/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[394/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[395/535] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[396/535] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[397/535] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[398/535] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[399/535] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[400/535] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[401/535] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[402/535] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[403/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[404/535] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[405/535] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[406/535] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[407/535] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[408/535] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[409/535] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
FAILED: src/CMakeFiles/server.dir/validation.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_ALL_NO_LIB -DBOOST_ATOMIC_DYN_LINK -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_SP_USE_STD_ATOMIC -DBOOST_THREAD_DYN_LINK -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/validation.cpp.o -MF src/CMakeFiles/server.dir/validation.cpp.o.d -o src/CMakeFiles/server.dir/validation.cpp.o -c ../../src/validation.cpp
../../src/validation.cpp: In member function ‘bool CChainState::ClearAvalancheFinalizedBlock()’:
../../src/validation.cpp:3744:1: error: no return statement in function returning non-void [-Werror=return-type]
 3744 | }
      | ^
cc1plus: all warnings being treated as errors
[410/535] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[411/535] Linking CXX static library src/wallet/libwallet.a
[412/535] Linking CXX static library src/wallet/libwallet-tool.a
[413/535] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
sdulfari updated this revision to Diff 37262.Dec 13 2022, 19:39

Rebase

Harbormaster completed remote builds in B21567: Diff 37262.Dec 13 2022, 19:50
teamcity added a comment.Dec 13 2022, 19:50
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc_p2p_avalanche_voting.py ======

------- Stdout: -------
2022-12-13T19:45:51.111000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20221213_194202/abc_p2p_avalanche_voting_50
2022-12-13T19:45:54.218000Z TestFramework (INFO): Poll for the chain tip...
2022-12-13T19:45:54.272000Z TestFramework (INFO): Poll for a selection of blocks...
2022-12-13T19:45:54.331000Z TestFramework (INFO): Poll for a selection of blocks, but some are now invalid...
2022-12-13T19:45:54.486000Z TestFramework (INFO): Poll for unknown blocks...
2022-12-13T19:45:54.541000Z TestFramework (INFO): Trigger polling from the node...
2022-12-13T19:45:54.904000Z TestFramework (INFO): Answer all polls to finalize...
2022-12-13T19:45:58.781000Z TestFramework (INFO): Answer all polls to park...
2022-12-13T19:46:15.793000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def has_finalized_new_tip():
            can_find_block_in_poll(hash_tip_final)
            return node.isfinalblock(fork_tip)
'''
2022-12-13T19:46:15.794000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 135, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_voting.py", line 228, in run_test
    self.wait_until(has_finalized_new_tip, timeout=15)
  File "/work/test/functional/test_framework/test_framework.py", line 703, in wait_until
    return wait_until_helper(test_function, timeout=timeout,
  File "/work/test/functional/test_framework/util.py", line 285, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
        def has_finalized_new_tip():
            can_find_block_in_poll(hash_tip_final)
            return node.isfinalblock(fork_tip)
''' not true after 15.0 seconds
2022-12-13T19:46:15.844000Z TestFramework (INFO): Stopping nodes
2022-12-13T19:46:15.996000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20221213_194202/abc_p2p_avalanche_voting_50
2022-12-13T19:46:15.996000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20221213_194202/abc_p2p_avalanche_voting_50/test_framework.log
2022-12-13T19:46:15.997000Z TestFramework (ERROR): 
2022-12-13T19:46:15.997000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20221213_194202/abc_p2p_avalanche_voting_50' to consolidate all logs
2022-12-13T19:46:15.997000Z TestFramework (ERROR): 
2022-12-13T19:46:15.997000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-12-13T19:46:15.997000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-12-13T19:46:15.997000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_p2p_avalanche_voting.py

sdulfari updated this revision to Diff 37265.Dec 13 2022, 20:18

Rebase

Harbormaster completed remote builds in B21570: Diff 37265.Dec 13 2022, 20:36
teamcity added a comment.Dec 13 2022, 20:36
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc_p2p_avalanche_voting.py ======

------- Stdout: -------
2022-12-13T20:28:26.130000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20221213_202530/abc_p2p_avalanche_voting_50
2022-12-13T20:28:29.175000Z TestFramework (INFO): Poll for the chain tip...
2022-12-13T20:28:29.230000Z TestFramework (INFO): Poll for a selection of blocks...
2022-12-13T20:28:29.301000Z TestFramework (INFO): Poll for a selection of blocks, but some are now invalid...
2022-12-13T20:28:29.470000Z TestFramework (INFO): Poll for unknown blocks...
2022-12-13T20:28:29.545000Z TestFramework (INFO): Trigger polling from the node...
2022-12-13T20:28:29.923000Z TestFramework (INFO): Answer all polls to finalize...
2022-12-13T20:28:33.957000Z TestFramework (INFO): Answer all polls to park...
2022-12-13T20:28:50.950000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def has_finalized_new_tip():
            can_find_block_in_poll(hash_tip_final)
            return node.isfinalblock(fork_tip)
'''
2022-12-13T20:28:50.950000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 135, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_voting.py", line 228, in run_test
    self.wait_until(has_finalized_new_tip, timeout=15)
  File "/work/test/functional/test_framework/test_framework.py", line 703, in wait_until
    return wait_until_helper(test_function, timeout=timeout,
  File "/work/test/functional/test_framework/util.py", line 285, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
        def has_finalized_new_tip():
            can_find_block_in_poll(hash_tip_final)
            return node.isfinalblock(fork_tip)
''' not true after 15.0 seconds
2022-12-13T20:28:51.001000Z TestFramework (INFO): Stopping nodes
2022-12-13T20:28:51.203000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20221213_202530/abc_p2p_avalanche_voting_50
2022-12-13T20:28:51.203000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20221213_202530/abc_p2p_avalanche_voting_50/test_framework.log
2022-12-13T20:28:51.203000Z TestFramework (ERROR): 
2022-12-13T20:28:51.203000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20221213_202530/abc_p2p_avalanche_voting_50' to consolidate all logs
2022-12-13T20:28:51.203000Z TestFramework (ERROR): 
2022-12-13T20:28:51.203000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-12-13T20:28:51.203000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-12-13T20:28:51.203000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_p2p_avalanche_voting.py

sdulfari updated this revision to Diff 37268.Dec 13 2022, 22:39

Rebase

Harbormaster completed remote builds in B21573: Diff 37268.Dec 13 2022, 22:56
sdulfari published this revision for review.Dec 13 2022, 23:05
Fabien accepted this revision.Dec 14 2022, 08:55
This revision is now accepted and ready to land.Dec 14 2022, 08:55
Closed by commit rABC3074dd676c26: [avalanche] Optimize block parking (authored by sdulfari). · Explain WhyDec 14 2022, 16:44
This revision was automatically updated to reflect the committed changes.
sdulfari added a commit: rABC3074dd676c26: [avalanche] Optimize block parking.

Revision Contents
Changeset List

PathSize
src/
9 lines

Diff 37262

View Options

src/validation.cpp

Loading...