Page MenuHomePhabricator
Differential D12901

bench, doc: benchmarking updates and fixups
ClosedPublic
Actions

Authored by Fabien on Dec 16 2022, 14:47.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC18ec6d07dcca: bench, doc: benchmarking updates and fixups
Summary

Backport of core#22292.

Depends on D12900.

Test Plan
ninja bench-bitcoin
./src/bench/bitcoin-bench -?

Read the doc.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 16 2022, 14:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 16 2022, 14:47
Fabien requested review of this revision.Dec 16 2022, 14:47
teamcity edited the summary of this revision. (Show Details)Dec 16 2022, 14:47
Fabien added a child revision: D12902: Drop boost/preprocessor dependencies.Dec 16 2022, 14:56
Harbormaster completed remote builds in B21604: Diff 37330.Dec 16 2022, 15:05
PiRK requested changes to this revision.Dec 16 2022, 15:08
PiRK added a subscriber: PiRK.
PiRK added inline comments.
doc/benchmarking.md
17 ↗(On Diff #37330)

Is there any reason for not adding the new AddrManAdd example that shows a ns/op result?

This revision now requires changes to proceed.Dec 16 2022, 15:08
Fabien added inline comments.Dec 16 2022, 15:14
doc/benchmarking.md
17 ↗(On Diff #37330)

Yes, an obvious reason: I missed it

Fabien updated this revision to Diff 37333.Dec 16 2022, 15:16

Add missing example

Harbormaster completed remote builds in B21607: Diff 37333.Dec 16 2022, 15:37
PiRK accepted this revision.Dec 16 2022, 16:08
This revision is now accepted and ready to land.Dec 16 2022, 16:08
Closed by commit rABC18ec6d07dcca: bench, doc: benchmarking updates and fixups (authored by Jon Atack <jon@atack.com>, committed by Fabien). · Explain WhyDec 16 2022, 16:58
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC18ec6d07dcca: bench, doc: benchmarking updates and fixups.

Revision Contents
Changeset List

PathSize
doc/
19 lines
src/
bench/
16 lines
12 lines

Diff 37335

View Options

doc/benchmarking.md

Loading...
View Options

src/bench/bench.h

Loading...
View Options

src/bench/bench_bitcoin.cpp

Loading...