Page MenuHomePhabricator
Differential D12903

bench: update nanobench add -min_time
ClosedPublic
Actions

Authored by Fabien on Dec 16 2022, 15:13.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCde6591d73286: bench: update nanobench add -min_time
Summary
This PR updates the nanobench with the latest release from upstream, v4.3.6. It fixes the missing performance counters.

Due to discussions on #22999 I have done some work that should make the benchmark results more reliable. It introduces a new flag -min_time that allows to run a benchmark for much longer then the default. When results are unreliable, choosing a large timeframe here should usually get repeatable results even when frequency scaling cannot be disabled. The default is now 10ms. For this to work I have changed the AddrManGood and EvictionProtection benchmarks so they work with any number of iterations.

Backport of core#23025.

Depends on D12902.

Test Plan
ninja bench-bitcoin
./src/bench/bitcoin-bench -?

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
bench/
45 lines
3 lines
16 lines
84 lines
8 lines
43 lines
10 lines
16 lines

Diff 37351

View Options

src/bench/addrman.cpp

Loading...
View Options

src/bench/bench.h

Loading...
View Options

src/bench/bench.cpp

Loading...
View Options

src/bench/bench_bitcoin.cpp

Loading...
View Options

src/bench/crypto_hash.cpp

Loading...
View Options

src/bench/nanobench.h

Loading...
View Options

src/bench/peer_eviction.cpp

Loading...
View Options

src/bench/rollingbloom.cpp

Loading...