Details

Reviewers

bytesofman
kieran709

Group Reviewers

Restricted Project

Commits

rABCb137fcf02fa4: [Cashtab] [Alias] pt 4 - Implement isAddressRegistered function

Summary

T2551

Depends on D12907

This diff fleshes out the isAddressRegistered function which is called upon loading the Alias component to check whether the current active wallet has any onchain aliases attached to it.

The payment address tx history retrieval logic was moved into it's own getAliasPaymentHistory function so that it can be reused by both isAddressRegistered and isAliasAvailable.

isAddressRegistered basically filters for valid incoming registration transactions at the alias payment address and extracts the hash160 of inputs[0] (the sender address of a valid registration tx) and compares it to the active wallet's hash160 (wallet.Path1899.hash160).

In later diffs the chronik API calls in isAddressRegistered will retrieve cached tx histories if the tx count of the alias payment address has not changed.

[Cashtab] [Alias] pt 1 - Create scaffold for new Identity component
[Cashtab] [Alias] pt 2 - Implement registerNewAlias() to handle alias registration
[Cashtab] [Alias] pt 3 - Implement isAliasAvailable function
[Cashtab] [Alias] pt 4 - Implement isAddressRegistered function
[Cashtab] [Alias] pt 5 - Implement getAddressFromAlias function
[Cashtab] [Alias] pt 6 - Implement isLocalAliasStateLatest function
[Cashtab] [Alias] pt 7 - Enable alias lookup for Send XEC component
[Cashtab] [Alias] pt 8 - Enable alias lookup for Send Token component
[Cashtab] [Alias] pt 9 - Implement pricing mechanism
[Cashtab] [Alias] pt 10 - Server cron job
[Cashtab] [Alias] pt 11 - Upgrade tx history to recognize alias registration txs

Test Plan

npm test
npm start
use a wallet that you have previously registered an alias with from part 3 of this stack
navigate to the Alias page and verify the 'Does this active wallet have an onchain alias? : true' console log message is displayed
switch to a wallet that did not previously register an alias then navigate to the Alias page and verify the 'Does this active wallet have an onchain alias? : false' console log message is displayed

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Errors

Severity	Location	Code	Message
Error	web/cashtab/src/utils/chronik.js:693	ESLINT	etc/no-commented-out-code

Unit

No Test Coverage

Build Status

Buildable 21689
Build 43018: Build Diff	cashtab-tests
Build 43017: arc lint + arc unit

Event Timeline

emack created this revision.Dec 18 2022, 04:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 18 2022, 04:22

emack requested review of this revision.Dec 18 2022, 04:22

emack edited the test plan for this revision. (Show Details)Dec 18 2022, 04:25

Harbormaster completed remote builds in B21621: Diff 37350.Dec 18 2022, 04:25

For both isAliasAvailable and isAddressRegistered, the input data should be the same. The missing piece here is a fetchAndCacheValidAliasesThroughLatestBlock function. This should return an object that looks something like

{
  validAliases = {registeredAliases: [{alias: alias1, address: address1}, {alias: alias2, address: address2}, ... , {alias: aliasN, address: addressN}] 
  validThruBlockheight: <blockheight where registeredAliases is valid through>
}

emack edited the summary of this revision. (Show Details)Dec 21 2022, 06:53

rebase

Harbormaster completed remote builds in B21659: Diff 37406.Dec 21 2022, 07:17

adjusted inline hash160 conversions in line with part 3
updated OP_RETURN parsing to following the prefix standard set in part 3

Harbormaster completed remote builds in B21661: Diff 37408.Dec 21 2022, 07:49

rebase

Harbormaster completed remote builds in B21685: Diff 37447.Jan 4 2023, 01:32

rebase

Harbormaster completed remote builds in B21689: Diff 37451.Jan 4 2023, 01:36

rebase

Harbormaster completed remote builds in B21693: Diff 37455.Jan 4 2023, 02:13

rebase

Harbormaster completed remote builds in B21708: Diff 37476.Jan 6 2023, 13:04

rebase

Harbormaster completed remote builds in B21755: Diff 37547.Jan 17 2023, 04:07

bytesofman requested changes to this revision.Jan 17 2023, 23:45

bytesofman added inline comments.

web/cashtab/src/utils/chronik.js
162 ↗	(On Diff #37547)	I'm not sure this function is necessary. Once this system is live, the behavior we want is On Cashtab load, update alias list to current blockheight If we have an `isAddressRegistered` function, it should only be checking localStorage As time goes on, we could add checkpoints -- i.e. add list of aliases, addresses, and blockheight to which the list is valid to `currency.Ticker` instead of `localStorage`, so that new Cashtab users aren't forced to parse the whole tx history of the alias address when they first use the app. So, instead of implementing caching in this function -- this function should just depend on the output of the `extractAliasesFromPaymentAddress` function from Part 2
164 ↗	(On Diff #37547)	local storage should preserve a list of valid alias registrations, their address, and the blockheight to which it is valid

This revision now requires changes to proceed.Jan 17 2023, 23:45

refactored isAddressRegistered to parse a mocked (for now) localStorage object rather than an onchain call to chronik
removed runtime hash160 address conversions as per D12907

Harbormaster completed remote builds in B21772: Diff 37571.Jan 18 2023, 12:53

rebase

Harbormaster completed remote builds in B21776: Diff 37575.Jan 18 2023, 12:55

bytesofman accepted this revision.Jan 18 2023, 14:25

This revision is now accepted and ready to land.Jan 18 2023, 14:25

emack added a child revision: D13015: [Cashtab] [Alias] pt 5 - Implement getAddressFromAlias function.Jan 20 2023, 01:50

rebase

Harbormaster completed remote builds in B21925: Diff 37804.Feb 3 2023, 03:02

rebase

Harbormaster completed remote builds in B22021: Diff 37938.Feb 17 2023, 23:08

Closed by commit rABCb137fcf02fa4: [Cashtab] [Alias] pt 4 - Implement isAddressRegistered function (authored by emack). · Explain WhyFeb 22 2023, 04:06

This revision was automatically updated to reflect the committed changes.