Page MenuHomePhabricator

Copy the smart pointer rather then the raw tx when adding a mempool tx to the wallet
ClosedPublic

Authored by Fabien on Dec 19 2022, 17:49.

Details

Summary

This will allow for making CTransaction non copyable, and force the use of CTransactionRef so we only keep a single pointer to a transaction for all its uses through the codebase.

Test Plan
ninja all check-all
./test/functional/test_runner.py wallet*
./contrib/teamcity/build-configurations.py build-asan

Event Timeline

Fabien requested review of this revision.Dec 19 2022, 17:49
PiRK added a subscriber: PiRK.

nit: in the summary, you probably meant "codebase" instead of "coinbase"

This revision is now accepted and ready to land.Dec 20 2022, 08:53
Fabien edited the summary of this revision. (Show Details)