Paths

Table of Contentst

Differential D12992

tests: Remove now-unnecessary manual Unload's
ClosedPublic
Actions

Authored by PiRK on Jan 18 2023, 11:19.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCf225386289d6: tests: Remove now-unnecessary manual Unload's

Summary

These manual calls to Unload() are no longer necessary because
CBlockIndex's no longer live in the heap as of the previous commit.

This is a partial backport of core#24050
https://github.com/bitcoin/bitcoin/pull/24050/commits/531dce034718523967808a89c18ba69a1e3e5a1f

Depends on D12991

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21769
Build 43173: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 43172: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 18 2023, 11:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 18 2023, 11:19

PiRK requested review of this revision.Jan 18 2023, 11:19

teamcity edited the summary of this revision. (Show Details)Jan 18 2023, 11:19

PiRK added a child revision: D12993: refactor: Rewrite InsertBlockIndex and AddToBlockIndex with try_emplace.Jan 18 2023, 11:21

Harbormaster completed remote builds in B21769: Diff 37566.Jan 18 2023, 11:34

Fabien accepted this revision.Jan 19 2023, 08:53

This revision is now accepted and ready to land.Jan 19 2023, 08:53

Closed by commit rABCf225386289d6: tests: Remove now-unnecessary manual Unload's (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyJan 20 2023, 15:22

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCf225386289d6: tests: Remove now-unnecessary manual Unload's.

Revision Contents
Changeset List

Path

Size

src/

test/

validation_chainstate_tests.cpp

3 lines

validation_chainstatemanager_tests.cpp

2 lines

Diff 37566

View Options

src/test/validation_chainstate_tests.cpp