Differential D13005

[avalanche] Consistently use the supplied ArgsManager
ClosedPublic
Actions

Authored by Fabien on Jan 19 2023, 13:15.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCeefdeca1ff34: [avalanche] Consistently use the supplied ArgsManager

Summary

An avoid using the global gArgs when possible.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_processor_argsman

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21790
Build 43215: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 43214: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 19 2023, 13:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 19 2023, 13:15

Fabien requested review of this revision.Jan 19 2023, 13:15

Harbormaster completed remote builds in B21790: Diff 37593.Jan 19 2023, 13:29

Fabien added a child revision: D13011: [avalanche] Add a facility for managing the command line options in the processor tests.Jan 19 2023, 15:58

PiRK accepted this revision.Jan 20 2023, 07:03

This revision is now accepted and ready to land.Jan 20 2023, 07:03

Closed by commit rABCeefdeca1ff34: [avalanche] Consistently use the supplied ArgsManager (authored by Fabien). · Explain WhyJan 20 2023, 14:30

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCeefdeca1ff34: [avalanche] Consistently use the supplied ArgsManager.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.cpp

4 lines

Diff 37593

View Options

src/avalanche/processor.cpp

[avalanche] Consistently use the supplied ArgsManagerClosedPublicActions